Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service map - Layout bug when there are not valid root nodes #62878

Closed
ogupte opened this issue Apr 7, 2020 · 0 comments · Fixed by #62887
Closed

[APM] Service map - Layout bug when there are not valid root nodes #62878

ogupte opened this issue Apr 7, 2020 · 0 comments · Fixed by #62887
Assignees
@ogupte
Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience v7.7.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Apr 7, 2020

When viewing a service map for a set of connection where each node has incoming edges, then no root node is selected, so the Layout displays services in unhelpful way:

Screen Shot 2020-04-07 at 3.51.49 PM.png
@ogupte ogupte added [zube]: In Progress bug Fixes for quality problems that affect the customer experience apm:service-maps Service Map feature in APM v7.7.0 labels Apr 7, 2020
@ogupte ogupte self-assigned this Apr 7, 2020
ogupte added a commit to ogupte/kibana that referenced this issue Apr 7, 2020
@ogupte
Closes elastic#62878 in Service Maps by improving the selection algor…
a8a52ac 
…ithm for root nodes
@ogupte ogupte mentioned this issue Apr 7, 2020
Merged
ogupte added a commit that referenced this issue Apr 8, 2020
@ogupte
[APM] Service map - fixes layout issues for maps with no rum services (…
184f594 
…#62887)

* Closes #62878 in Service Maps by improving the selection algorithm for root nodes

* Fixes some latent centering issues when navigating in the service map.

* Removes unused imports

* Added layoutstopDelayTimeout to cleanup step
ogupte added a commit to ogupte/kibana that referenced this issue Apr 8, 2020
@ogupte
[APM] Service map - fixes layout issues for maps with no rum services (…
3e68d09 
…elastic#62887)

* Closes elastic#62878 in Service Maps by improving the selection algorithm for root nodes

* Fixes some latent centering issues when navigating in the service map.

* Removes unused imports

* Added layoutstopDelayTimeout to cleanup step
ogupte added a commit to ogupte/kibana that referenced this issue Apr 8, 2020
@ogupte
[APM] Service map - fixes layout issues for maps with no rum services (…
01cbbe8 
…elastic#62887)

* Closes elastic#62878 in Service Maps by improving the selection algorithm for root nodes

* Fixes some latent centering issues when navigating in the service map.

* Removes unused imports

* Added layoutstopDelayTimeout to cleanup step
ogupte added a commit that referenced this issue Apr 9, 2020
@ogupte
[APM] Service map - fixes layout issues for maps with no rum services (…
0dd2858 
…#62887) (#63002)

* Closes #62878 in Service Maps by improving the selection algorithm for root nodes

* Fixes some latent centering issues when navigating in the service map.

* Removes unused imports

* Added layoutstopDelayTimeout to cleanup step
ogupte added a commit that referenced this issue Apr 9, 2020
@ogupte
[APM] Service map - fixes layout issues for maps with no rum services (…
c13acac 
…#62887) (#63003)

* Closes #62878 in Service Maps by improving the selection algorithm for root nodes

* Fixes some latent centering issues when navigating in the service map.

* Removes unused imports

* Added layoutstopDelayTimeout to cleanup step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Service map - fixes layout issues for maps with no rum services ogupte/kibana
2 participants
@sorenlouv @ogupte