Deprecate defaultAppId in favor of defaultRoute #6902
Comments
|
Want to deprecate it first? The new deprecated config stuff that is about to get merged would make that a one liner. |
|
@epixa It doesn't actually do anything currently, it was already replaced. There's still a default value, but it isn't used for anything. I labelled this breaking because when the defaults are removed it will cause the config to throw an error, but the actual behavior break was a long time ago |
|
Ah, I understand. |
|
@rashidkpc @epixa just to be clear, in 4.x this worked (and still works in 4.5 GA) for the purposes of loading a default dashboard at startup: So users upgrading from those versions will indeed perceive this as a breaking change. Should we add defaultRoute to kibana.yml? I don't see it there in the latest snapshot. Will that setting be able to achieve the same functionality as above? |
|
Ah, I thought we removed it before then, my bad. Yeah, we can deprecate. And yes, defaultRoute accomplishes the same thing. |
epixa
changed the title
|
I updated the title of the issue to reflect that. |
|
We need to add this setting to the configuring Kibana documentation! |
|
I was one of those who used this functionality, so, while it might not be widely used, this change is frustrating to those who did use it. The functionality of server.defaultRoute not a direct replacement to the old method, you used to be able to use the human readable name, but now since the URL uses the ID instead of the human readable name you cannot set a particular dashboard as a landing page as I had done previously using config management tools (salt in my case - without keeping a track of the ID for each new server you set up and importing that in on a host by host basis, which is messy) as the id will be different for each server that is set up. I have raised this as a separate issue here: #14417 Thanks |
|
|
## Summary `eui@83.1.0` ⏩ `eui@84.0.0` --- ## [`84.0.0`](https://github.com/elastic/eui/tree/v84.0.0) - Updated `EuiDualRange`'s `minInputProps` and `maxInputProps` to support passing more props to underlying inputs ([#6902](elastic/eui#6902)) - `EuiFocusTrap` now supports configuring cross-iframe focus trapping via the `crossFrame` prop ([#6908](elastic/eui#6908)) **Bug fixes** - Fixed `EuiFilterButton` icon display ([#6900](elastic/eui#6900)) - Fixed `EuiCombobox` compressed plain text display ([#6910](elastic/eui#6910)) - Fixed visual appearance of collapse buttons on collapsible `EuiResizablePanel`s ([#6926](elastic/eui#6926)) **Breaking changes** - `EuiFocusTrap` now defaults to *not* trapping focus across iframes ([#6908](elastic/eui#6908)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Its been replaced with
defaultRoute, we don't need defaultAppId any more. This will be a breaking change but should affect too many people since defaultAppId has always been wonky and I doubt its particularly widely used.The text was updated successfully, but these errors were encountered: