Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Investigate moving ES aggregation types to @elastic/elasticsearch #77720

Closed
dgieselaar opened this issue Sep 17, 2020 · 3 comments
Closed

[APM] Investigate moving ES aggregation types to @elastic/elasticsearch #77720

dgieselaar opened this issue Sep 17, 2020 · 3 comments
Assignees
@dgieselaar
Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture

Comments

@dgieselaar
Copy link
Member

If possible, we want to make the aggregation types that we have available for all users of the new elasticsearch client. We should look at the types the client has and how it can be combined. The goal of this investigation should be to have a clear next step towards the goal of having our aggregation types in the client itself.
@dgieselaar dgieselaar added the Team:APM All issues that need APM UI Team support label Sep 17, 2020
@dgieselaar dgieselaar self-assigned this Sep 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added [zube]: Backlog technical debt Improvement of the software architecture and operational architecture labels Sep 18, 2020
@smith smith mentioned this issue Oct 21, 2020
Merged
3 tasks
@smith
Copy link
Contributor

smith commented Nov 5, 2020 •
edited
Loading

This also has implications for the TS project references migration (#80508.)

These plugins or projects use the APM typings, and possibly create circular references with APM:

  • lens
  • taskManager

smith added a commit to smith/kibana that referenced this issue Nov 10, 2020
@smith
Move Elasticsearch type definitions out of APM
feffa04 
...and into x-pack.

Also remove `PromiseReturnType` from APM and use the copy in observability everywhere.

All of the additional changes to APM imports are just automatic sorting.

This makes doing elastic#77720 a little easier and removes some implicit circular dependencies for elastic#80508.
@smith smith mentioned this issue Nov 10, 2020
Merged
smith added a commit that referenced this issue Nov 11, 2020
@smith @dgieselaar
Move Elasticsearch type definitions out of APM (#83081)
bc2da67 
...and into x-pack.

Also remove `PromiseReturnType` from APM and use the copy in observability everywhere.

All of the additional changes to APM imports are just automatic sorting.

This makes doing #77720 a little easier and removes some implicit circular dependencies for #80508.

Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
smith added a commit to smith/kibana that referenced this issue Nov 11, 2020
@smith
Move Elasticsearch type definitions out of APM (elastic#83081)
1a68aa0 
...and into x-pack.

Also remove `PromiseReturnType` from APM and use the copy in observability everywhere.

All of the additional changes to APM imports are just automatic sorting.

This makes doing elastic#77720 a little easier and removes some implicit circular dependencies for elastic#80508.

Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
# Conflicts:
#	x-pack/plugins/apm/public/utils/testHelpers.tsx
smith added a commit that referenced this issue Nov 12, 2020
@smith
Move Elasticsearch type definitions out of APM (#83081) (#83229)
fabfc54 
...and into x-pack.

Also remove `PromiseReturnType` from APM and use the copy in observability everywhere.

All of the additional changes to APM imports are just automatic sorting.

This makes doing #77720 a little easier and removes some implicit circular dependencies for #80508.

Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
# Conflicts:
#	x-pack/plugins/apm/public/utils/testHelpers.tsx
@dgieselaar
Copy link
Member Author

Not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smith @sorenlouv @dgieselaar @elasticmachine