Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: exports a "ip" list from an uploaded file - value lists management modal export list types exports a "ip" list from an uploaded file #84014

Closed
kibanamachine opened this issue Nov 21, 2020 · 2 comments
Closed

Failing test: exports a "ip" list from an uploaded file - value lists management modal export list types exports a "ip" list from an uploaded file #84014

kibanamachine opened this issue Nov 21, 2020 · 2 comments
Assignees
@FrankHassanabad
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Rule Value Lists Security Solution Detection Rule Value Lists

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 21, 2020 •
edited
Loading

A test failed on a tracked branch

AssertionError: expected '' to include '127.0.0.1'
    at Context.eval (http://localhost:6131/__cypress/tests?p=cypress/integration/value_lists.spec.ts:15212:53)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Nov 21, 2020
@FrankHassanabad FrankHassanabad self-assigned this Nov 21, 2020
@FrankHassanabad FrankHassanabad added the Feature:Rule Value Lists Security Solution Detection Rule Value Lists label Nov 21, 2020
@FrankHassanabad FrankHassanabad mentioned this issue Nov 21, 2020
Merged
1 task
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

FrankHassanabad added a commit that referenced this issue Nov 23, 2020
@FrankHassanabad
Adds safe guards against in-determinism by checking list items after …
24c7b2d 
…uploads (#84015)

## Summary

Fixes flakey tests by adding explicit list value upload items through either the fixture that was uploaded or by a specific test value in case the uploaded list is a range value. Also filters out any empty values for more safeguards from prettier formatters that add them to fixture files.

#84014

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this issue Nov 23, 2020
@FrankHassanabad
Adds safe guards against in-determinism by checking list items after …
e2d8741 
…uploads (elastic#84015)

## Summary

Fixes flakey tests by adding explicit list value upload items through either the fixture that was uploaded or by a specific test value in case the uploaded list is a range value. Also filters out any empty values for more safeguards from prettier formatters that add them to fixture files.

elastic#84014

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
FrankHassanabad added a commit that referenced this issue Nov 23, 2020
@FrankHassanabad
Adds safe guards against in-determinism by checking list items after …
4ca7a68 
…uploads (#84015) (#84098)

## Summary

Fixes flakey tests by adding explicit list value upload items through either the fixture that was uploaded or by a specific test value in case the uploaded list is a range value. Also filters out any empty values for more safeguards from prettier formatters that add them to fixture files.

#84014

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@FrankHassanabad
Copy link
Contributor

Should be fixed from the ticket linked, closing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankHassanabad FrankHassanabad

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Rule Value Lists Security Solution Detection Rule Value Lists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FrankHassanabad @kibanamachine