Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUI][Data] - Add index field selectors to EUI or Data #94875

Open
yctercero opened this issue Mar 17, 2021 · 7 comments
Open

[EUI][Data] - Add index field selectors to EUI or Data #94875

yctercero opened this issue Mar 17, 2021 · 7 comments
Labels
EUI impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@yctercero
Copy link
Contributor

Describe the feature:

Currently the security solutions team is working to move exception list UI into the lists plugin. In doing so, it's clear that a number of areas use similar components and that similar components exist within other plugins like data. I'll try to dig into the shared functionality and areas where it's being used as best I can to demonstrate that a streamlined component could be useful.

With the RAC initiative (unified alerting experience), these components will start being used in other plugins like observability.

Describe a specific use case for the feature:
Below are some of the areas in which this component shows up. data plugin has had a version for a while. When we were building out exceptions we chose not to use theirs because we weren't able to customize which operators could be used and it didn't have support for nested fields (at least not displayed the way we wanted).

Common functionality

  • Pass an index pattern into component that determines what fields to show in the initial selector
  • Operators - not all use multiple operators or the same operators, but all do have the same basic principle some field is some value
  • Value selection includes autocomplete
    • This is where I think maybe it's a better component to be maintained in data possibly?
  • Allows multiple of these to be AND-ed or OR-ed in some cases it's logic that is abstracted. Adding filters for example, it has you do one at a time as opposed to allowing the user to explicitly AND it

Exceptions

  • Code is being moved into the lists plugin

Screen Shot 2021-03-17 at 3 08 43 PM

Example of exceptions with nested

Screen Shot 2021-03-17 at 3 22 16 PM

Indicator Match Rule

  • Exceptions code was forked and lives within security solution

Screen Shot 2021-03-17 at 3 09 51 PM

Trusted Apps

  • Exceptions code was forked and lives within security solution

Screen Shot 2021-03-17 at 3 11 08 PM

Adding a Filter

  • Code from data plugin

Screen Shot 2021-03-17 at 3 09 38 PM

Severity Override

  • Left a copy of the autocomplete components

Screen Shot 2021-03-17 at 3 10 33 PM

@yctercero yctercero added EUI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Mar 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@yctercero
Copy link
Contributor Author

@lizozom I think @spong had mentioned that you previously talked about something similar? I know we chatted back when exceptions was being built out and found that we couldn't use the existing data components.

@yctercero
Copy link
Contributor Author

A low-hanging fruit here would be to hoist up the rounded badge into EUI as it will now be in 3 different plugins (lists, observability, security solution):
image

@pgayvallet
Copy link
Contributor

A low-hanging fruit here would be to hoist up the rounded badge into EUI as it will now be in 3 different plugins

Why EUI and not simply an utility component?

@cchaos
Copy link
Contributor

cchaos commented Mar 25, 2021

I will agree, that the rounded badge seems very particular to this component in the way that it's displayed along with the connecting dots.

I would be worried about making this a very specific EUI component. But I do agree that all these places could probably benefit from the same UI. I would recommend starting with a shared component/utility in Kibana and work to replace those places mentioned with this new component to see how well it works before we consider pulling it up to EUI.

Does that seem like an ok approach?

@peluja1012 peluja1012 added the Team:Security Solution Platform Security Solution Platform Team label Oct 22, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 4, 2021
@yctercero yctercero added Team:Detection Engine Security Solution Detection Engine Area and removed Team:Security Solution Platform Security Solution Platform Team labels May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EUI impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

5 participants