[Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items #100853

academo · 2021-05-28T09:12:18Z

Summary

Do not display the search bar in the Security Administration - Trusted Apps panel if there are no items to filter out.

In addition fix two ts-server warnings in non-related tests in the same test file.

Before

After

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-05-28T09:17:05Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

ashokaditya · 2021-05-28T09:22:17Z

...ugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_page.test.tsx

@@ -555,7 +563,7 @@ describe('When on the Trusted Apps Page', () => {
          // to test the UI behaviours while the API call is in flight
          coreStart.http.post.mockImplementation(
            // @ts-ignore
-            async (path: string, options: HttpFetchOptions) => {
+            async (_path: string, options: HttpFetchOptions) => {


dasansol92 · 2021-05-28T09:29:32Z

...ugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_page.test.tsx

@@ -555,7 +563,7 @@ describe('When on the Trusted Apps Page', () => {
          // to test the UI behaviours while the API call is in flight
          coreStart.http.post.mockImplementation(
            // @ts-ignore
-            async (path: string, options: HttpFetchOptions) => {
+            async (_path: string, options: HttpFetchOptions) => {


Out of curiosity, why did you changed this path to _path ?

to silence the ts-warning about non used parameter.

That make sense. Personally I prefer to set an underscore without type since it's not going to be used, but both works in the same way:

async (_, options: HttpFetchOptions) => {

Thanks for fixing this warning 🤗

Indeed, it looks way better. I'll do that next time :)

I decided to change it in this PR

dasansol92

It LGTM!! Thanks for adding new test cases for this!! 🔥 🔥 🔥 🚢

Remove type and name from unused parameter

academo · 2021-05-28T10:55:03Z

@elasticmachine merge upstream

…-95911

kibanamachine · 2021-05-28T12:40:51Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.9MB	6.9MB	+136.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`fleet`	22	20	-2

History

💔 Build #127847 failed 294dd76
💔 Build #127844 failed 6b552c9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…usted apps if there are no items (elastic#100853) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-05-28T13:22:04Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…usted apps if there are no items (#100853) (#100877) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>

* master: (77 commits) [RAC][Security Solution] Register Security Detection Rules with Rule Registry (elastic#96015) [Enterprise Search] Log warning for Kibana/EntSearch version mismatches (elastic#100809) updating the saved objects test to include more saved object types (elastic#100828) [ML] Fix categorization job view examples link when datafeed uses multiple indices (elastic#100789) Fixing ES archive mapping failure (elastic#100835) Fix bug with Observability > APM header navigation (elastic#100845) [Security Solution][Endpoint] Add event filters summary card to the fleet endpoint tab (elastic#100668) [Actions] Taking space id into account when creating email footer link (elastic#100734) Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (elastic#100823) [Security Solution] Improve find rule and find rule status route performance (elastic#99678) [DOCS] Adds video to introduction (elastic#100906) [Fleet] Improve combo box for fleet settings (elastic#100603) [Security Solution][Endpoint] Endpoint generator and data loader support for Host Isolation (elastic#100813) [DOCS] Adds Lens video (elastic#100898) [TSVB] [Table tab] Fix "Math" aggregation (elastic#100765) chore(NA): moving @kbn/io-ts-utils into bazel (elastic#100810) [Alerting] Adding feature flag for enabling/disabling rule import and export (elastic#100718) [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864) [Lens] Adds dynamic table cell coloring (elastic#95217) [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (elastic#100853) ...

academo added 2 commits May 28, 2021 09:56

Render the trusted apps searchbar only where there are items to filter

2dc5fb0

Add tests to check for searchbar display in trusted apps view

6b552c9

academo requested review from dasansol92 and paul-tavares May 28, 2021 09:12

academo requested a review from a team as a code owner May 28, 2021 09:12

academo changed the title ~~Do not display searchbar in security-trusted apps if there are no items~~ [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items May 28, 2021

academo added v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels May 28, 2021

academo added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels May 28, 2021

academo linked an issue May 28, 2021 that may be closed by this pull request

[ Enhancement ] Search bar should not be displayed when there is no Trusted Application added #95911

Closed

2 tasks

ashokaditya approved these changes May 28, 2021

View reviewed changes

dasansol92 reviewed May 28, 2021

View reviewed changes

dasansol92 approved these changes May 28, 2021

View reviewed changes

Move test to its correct section

294dd76

Remove type and name from unused parameter

Merge branch 'master' into fix/trustedapps_searchbar_no_display_empty…

e62f1be

…-95911

academo merged commit 4b486d3 into elastic:master May 28, 2021

academo deleted the fix/trustedapps_searchbar_no_display_empty-95911 branch May 28, 2021 13:19

kibanamachine mentioned this pull request May 28, 2021

[7.x] [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (#100853) #100877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items #100853

[Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items #100853

academo commented May 28, 2021

elasticmachine commented May 28, 2021

ashokaditya May 28, 2021

dasansol92 May 28, 2021 •

edited

Loading

academo May 28, 2021

dasansol92 May 28, 2021

academo May 28, 2021

academo May 28, 2021

dasansol92 left a comment

academo commented May 28, 2021

kibanamachine commented May 28, 2021

References to deprecated APIs

kibanamachine commented May 28, 2021

[Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items #100853

[Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items #100853

Conversation

academo commented May 28, 2021

Summary

Checklist

For maintainers

elasticmachine commented May 28, 2021

ashokaditya May 28, 2021

Choose a reason for hiding this comment

dasansol92 May 28, 2021 • edited Loading

Choose a reason for hiding this comment

academo May 28, 2021

Choose a reason for hiding this comment

dasansol92 May 28, 2021

Choose a reason for hiding this comment

academo May 28, 2021

Choose a reason for hiding this comment

academo May 28, 2021

Choose a reason for hiding this comment

dasansol92 left a comment

Choose a reason for hiding this comment

academo commented May 28, 2021

kibanamachine commented May 28, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

References to deprecated APIs

History

kibanamachine commented May 28, 2021

💚 Backport successful

dasansol92 May 28, 2021 •

edited

Loading