-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sample data] Use Lens in flights dashboard #104780
Conversation
jenkins, test this (had to abort for Jenkins upgrade) |
Wylie thanks for asking about the chages. It's a big improvement in a number of ways 🎉 eg.
In some future version it'd be good to change the red/green color pair in the heatmap to a more accessible categorical color set, and as the surface area of the heatmap and esp. the individual cells is a bit high (due to having only two columns) a more muted color palette may work better. I'm also wondering if maybe all of the time series are worth putting below one another, assuming their time domain is shared. Maybe binning could be in sync too, eg. flight counts and delays sharing the same time resolution. For some reason it also feels that the maps would be neat side by side, as both could then be visible simultaneously. There are the following main parts to this report(*), in the approx. order of importance, give or take. There are legitimate alternative orders of importance (depends on the use), so this is only for example:
It's useful for a report to convey a clear visual hierarchy, eg. starting with the maps (side by side, full width, and substantial height), so its placement and size identifies it as the anchor element. Then the time series form a somewhat monolithic, aligned block with internal vertical and horizontal rythm - the 2nd most important bit. The auxiliary charts can be on the right. The table, below, esp. if it needs that many columns. (*) I'm calling it a report, because a dashboard needs to fit on a fixed screen area, eg. one specific screen. In the future I hope our dashboards will be fixed screen, or somewhat responsive dashboards that show all charts even if shrunken, or simplify or even cull charts, but never scroll. What scrolls, or would otherwise has overflow is something else, eg. a report, notebook or journal article. |
The new dashboard looks very nice and has a more gentle learning curve. I've used the Also, it would be nice to use the transpose feature somewhere, but I could not come up with a nice combination (Origin x Destination may be nice).
Agree with @monfera on this. That said I like the current layout apart from having the maps stacked, which makes it harder to track them together as I often found myself scrolling up and down the dashboard. |
@monfera and @dej611 thanks for the feedback, I've taken most of it and I'm not sure what to do about the rest that I haven't applied here. Specifically, here are the parts I didn't take:
Here's the update: |
Much better with the new layout and the cleaner palette on the datatable 👍 |
}, | ||
minSize: 1, | ||
maxSize: 32, | ||
maxSize: 16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the maxSize to 32 and the minSize to 4 so the markers stand out better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nreese Sure, I can make this change, but the main reason I reduced the size was to deal with overlapping circles at the zoomed out map. Any thoughts on the tradeoff between those two priorities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overlapping circles are better then a nearly empty map in the default view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The new dashboard looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app services changes LGTM
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* [Sample data] Use Lens in flights sample data * Fix test issues * Fix functional tests * Fix a11y test names * Fix tests again * Fix test * Update from comments * Fix sizing from feedback * Fix typo Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* [Sample data] Use Lens in flights sample data * Fix test issues * Fix functional tests * Fix a11y test names * Fix tests again * Fix test * Update from comments * Fix sizing from feedback * Fix typo Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
Not only have I changed the flights dashboard to use Lens instead of Visualize where possible, I've also made changes to the content of the dashboard. The goal of this dashboard is now to analyze the origin of delayed and cancelled flights, instead of having mixed types of panels.
In Lens, I'm specifically adding a week over week formula and conditionally colored tables, which are highlighting the newest features.
Part of #77340
Before
After