Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] fix "edit" button on empty dashboard #11031

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Apr 5, 2017

Fixes #10975

The KbnTopNav didn't use to support programmatically interacting with menu items that were "actions", but this adds an api to click() action items by key and uses that to trigger the "edit" action.

Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spalger
Copy link
Contributor Author

spalger commented Apr 7, 2017

5.x: f14b333

@spalger spalger deleted the fix/empty-dashboard-edit-button branch August 18, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants