Fix the save as warning in dashboard save panel #11107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
changed the title
|
Failed due to #11110 jenkins, test this. |
It was removed with view/edit mode. TODO: tests.
stacey-gammon
force-pushed
the
dashboard-save-warning
branch
from
208387a
to
17ce141
Compare
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Apr 10, 2017
It was removed with view/edit mode. TODO: tests.
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Apr 11, 2017
It was removed with view/edit mode. TODO: tests.
stacey-gammon
added a commit
that referenced
this pull request
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning was accidentally broken by the introduction of view/edit mode.
Addresses #11076
I'll leave the issue open until I add tests for it, but don't want to do so until #10910 is checked in since it makes so many test related changes.