[Alerting] Showing last execution duration on Rule Management view #113935

ymao1 · 2021-10-05T13:45:25Z

Relates to #111805

This addresses the rule management view portion of the issue. Will have separate PR for rule details view when those mocks become available.

Summary

Added last execution duration as a field inside the executionStatus of the rule saved object.
Adding last execution duration as a column on the Rules Management view. Also tweaked the table to reflect mockups.

UI Changes:

moved rule type as a second line the rule name column instead of its own column
changed tags list into a button showing # of tags with popover
added "Last run" column
added "Duration" column
removed # Actions column

Tooltip describing duration column

Warning indicator when rule duration exceeds the configured rule timeout value

Tags popover

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

…utes

…ing/show-durations-rule-mgmt

ymao1 · 2021-10-06T14:07:42Z

...iggers_actions_ui/public/application/sections/alerts_list/components/alert_status_filter.tsx

@@ -99,10 +99,10 @@ export function getHealthColor(status: AlertExecutionStatuses) {
    case 'error':
      return 'danger';
    case 'ok':
-      return 'subdued';
+      return 'primary';


Changed these colors to reflect mockup.

elasticmachine · 2021-10-06T14:09:15Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1 · 2021-10-06T14:11:12Z

Tagging @gchaps to review copy on tooltips (can be seen in screenshots in the PR summary)

…m/ymao1/kibana into alerting/show-durations-rule-mgmt

ymao1 · 2021-10-07T19:25:51Z

Suggestions for tooltip #1:

The time it took for the rule to run to completion.

The length of time it took for the rule to run.

Tooltip #2:

Duration exceeds the rule's expected run time.

@gchaps Thanks! Updated in this commit: cccf8d1

brianseeders · 2021-10-07T20:33:04Z

Hey @ymao1, just noticed you were running in buildkite, then went back to Jenkins. Was that just because of the test failures?

ymao1 · 2021-10-07T20:38:25Z

@brianseeders i was trying to see if one was faster than the other :) but I actually forgot to check the total runtime

brianseeders · 2021-10-07T20:40:19Z

Ah, okay. They should be about the same at the moment. I have a PR open though that reduces the overall time by 40 minutes, but we have to wait until we've fully moved over to merge it

ymao1 · 2021-10-11T11:46:51Z

@elasticmachine merge upstream

chrisronline

LGTM!

…m/ymao1/kibana into alerting/show-durations-rule-mgmt

gchaps

tooltip text looks good to me

YulNaumenko

LGTM

ymao1 · 2021-10-11T23:04:07Z

@elasticmachine merge upstream

kibanamachine · 2021-10-12T01:06:33Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`alerting`	245	249	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	760.3KB	762.7KB	+2.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`alerting`	36.5KB	36.9KB	+369.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`alert`	34	35	+1

Unknown metric groups

API count

id	before	after	diff
`alerting`	253	257	+4

History

💛 Build #159692 was flaky 05719eb
💚 Build #159466 succeeded bad9ecb
💚 Build #159135 succeeded 129c686
💚 Build #159119 succeeded dff8adb
💚 Build #159055 succeeded b6de154

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

…lastic#113935) * Adding last duration to execution status and returning in alerting routes * Fixing types * Adding helper function to format duration * Returning rule timeout value in list rules API * Updating rules table to add duration column and tweaks to match mockup * Updating rules table to add duration column and tweaks to match mockup * i18n fix * Only showing duration warning if duration is long * Unit tests * i18n fix * Fixing functional test * Aligning warning icon * Reset last duration when rule is disabled then reenabled * Fixing functional test * Fixing functional test * Restoring muted badge. Fixing scss * Dont show muted badge if rule is disabled * Moving disabled icontip to right of rule name * Updating tooltips * Updating last run Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-10-12T01:14:06Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…113935) (#114584) * Adding last duration to execution status and returning in alerting routes * Fixing types * Adding helper function to format duration * Returning rule timeout value in list rules API * Updating rules table to add duration column and tweaks to match mockup * Updating rules table to add duration column and tweaks to match mockup * i18n fix * Only showing duration warning if duration is long * Unit tests * i18n fix * Fixing functional test * Aligning warning icon * Reset last duration when rule is disabled then reenabled * Fixing functional test * Fixing functional test * Restoring muted badge. Fixing scss * Dont show muted badge if rule is disabled * Moving disabled icontip to right of rule name * Updating tooltips * Updating last run Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: ymao1 <ying.mao@elastic.co>

ymao1 added 7 commits October 5, 2021 09:44

Adding last duration to execution status and returning in alerting ro…

25d8ffa

…utes

Fixing types

b7d8f7f

Merge branch 'master' of https://github.com/elastic/kibana into alert…

caf6942

…ing/show-durations-rule-mgmt

Adding helper function to format duration

19dd9ab

Returning rule timeout value in list rules API

4ba2829

Updating rules table to add duration column and tweaks to match mockup

4769504

Updating rules table to add duration column and tweaks to match mockup

0e24e12

ymao1 changed the title ~~[Alerting] Showing last execution duration on Rule Management view~~ [Alerting][skip-ci] Showing last execution duration on Rule Management view Oct 5, 2021

ymao1 added the buildkite-ci label Oct 5, 2021

ymao1 added 7 commits October 5, 2021 16:11

i18n fix

21ca375

Merge branch 'master' of https://github.com/elastic/kibana into alert…

804c290

…ing/show-durations-rule-mgmt

Only showing duration warning if duration is long

f0991ee

Unit tests

d1a4bb9

i18n fix

b018856

Fixing functional test

99f3aa8

Merge branch 'master' of https://github.com/elastic/kibana into alert…

00672d0

…ing/show-durations-rule-mgmt

ymao1 self-assigned this Oct 6, 2021

ymao1 added Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) UX v7.16.0 v8.0.0 labels Oct 6, 2021

ymao1 commented Oct 6, 2021

View reviewed changes

ymao1 marked this pull request as ready for review October 6, 2021 14:09

ymao1 requested a review from a team as a code owner October 6, 2021 14:09

ymao1 requested review from mdefazio and gchaps October 6, 2021 14:10

Merge branch 'alerting/show-durations-rule-mgmt' of https://github.co…

dff8adb

…m/ymao1/kibana into alerting/show-durations-rule-mgmt

Updating last run

129c686

ymao1 requested a review from chrisronline October 7, 2021 20:05

Merge branch 'master' into alerting/show-durations-rule-mgmt

bad9ecb

chrisronline approved these changes Oct 11, 2021

View reviewed changes

ymao1 added 2 commits October 11, 2021 15:57

Merging in master

f08138c

Merge branch 'alerting/show-durations-rule-mgmt' of https://github.co…

05719eb

…m/ymao1/kibana into alerting/show-durations-rule-mgmt

gchaps approved these changes Oct 11, 2021

View reviewed changes

YulNaumenko approved these changes Oct 11, 2021

View reviewed changes

Merge branch 'master' into alerting/show-durations-rule-mgmt

ca3379e

ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 11, 2021

ymao1 enabled auto-merge (squash) October 11, 2021 23:04

ymao1 merged commit c926b14 into elastic:master Oct 12, 2021

kibanamachine mentioned this pull request Oct 12, 2021

[7.x] [Alerting] Showing last execution duration on Rule Management view (#113935) #114584

Merged

ymao1 mentioned this pull request Dec 3, 2021

Display last execution date in the alert list and/or details page #88476

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerting] Showing last execution duration on Rule Management view #113935

[Alerting] Showing last execution duration on Rule Management view #113935

ymao1 commented Oct 5, 2021 •

edited

Loading

ymao1 Oct 6, 2021

elasticmachine commented Oct 6, 2021

ymao1 commented Oct 6, 2021

ymao1 commented Oct 7, 2021

brianseeders commented Oct 7, 2021

ymao1 commented Oct 7, 2021

brianseeders commented Oct 7, 2021

ymao1 commented Oct 11, 2021

chrisronline left a comment

gchaps left a comment

YulNaumenko left a comment

ymao1 commented Oct 11, 2021

kibanamachine commented Oct 12, 2021

API count

kibanamachine commented Oct 12, 2021

[Alerting] Showing last execution duration on Rule Management view #113935

[Alerting] Showing last execution duration on Rule Management view #113935

Conversation

ymao1 commented Oct 5, 2021 • edited Loading

Summary

Checklist

ymao1 Oct 6, 2021

Choose a reason for hiding this comment

elasticmachine commented Oct 6, 2021

ymao1 commented Oct 6, 2021

ymao1 commented Oct 7, 2021

brianseeders commented Oct 7, 2021

ymao1 commented Oct 7, 2021

brianseeders commented Oct 7, 2021

ymao1 commented Oct 11, 2021

chrisronline left a comment

Choose a reason for hiding this comment

gchaps left a comment

Choose a reason for hiding this comment

YulNaumenko left a comment

Choose a reason for hiding this comment

ymao1 commented Oct 11, 2021

kibanamachine commented Oct 12, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

Saved Objects .kibana field count

API count

History

kibanamachine commented Oct 12, 2021

💚 Backport successful

ymao1 commented Oct 5, 2021 •

edited

Loading