Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vega] Debounce duplicate error messages #116408

Merged
merged 4 commits into from
Nov 9, 2021

Conversation

DianaDerevyankina
Copy link
Contributor

@DianaDerevyankina DianaDerevyankina commented Oct 27, 2021

Closes #114288

Summary

Implemented solution to avoid duplication of the same vega messages.

vega debounce messages demo

For maintainers

@DianaDerevyankina DianaDerevyankina added release_note:enhancement Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 27, 2021
@DianaDerevyankina DianaDerevyankina self-assigned this Oct 27, 2021
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@alexwizp alexwizp requested a review from dej611 October 28, 2021 14:33
@DianaDerevyankina DianaDerevyankina marked this pull request as ready for review November 9, 2021 08:07
@DianaDerevyankina DianaDerevyankina requested a review from a team as a code owner November 9, 2021 08:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@DianaDerevyankina DianaDerevyankina added backport:skip This commit does not require backporting v8.1.0 labels Nov 9, 2021
@DianaDerevyankina
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only (I've tested locally when in draft). 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVega 1.9MB 1.9MB +91.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@DianaDerevyankina DianaDerevyankina merged commit c48ef8a into elastic:main Nov 9, 2021
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Nov 10, 2021
* [Vega] Debounce duplicate error messages

* Update filter logic to avoid errors

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
* [Vega] Debounce duplicate error messages

* Update filter logic to avoid errors

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
* [Vega] Debounce duplicate error messages

* Update filter logic to avoid errors

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Vega Vega visualizations release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Vega] Debounce duplicate error messages
6 participants