[indexPatterns] update field in place #11966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
approved these changes
May 23, 2017
| fields.push(field); | ||
| const index = fields.findIndex(f => f.name === field.name); | ||
| if (index > -1) { | ||
| fields.splice(index, 1, field); |
There was a problem hiding this comment.
You could also assign to the index, might be simpler to read:
fields[index] = field;There was a problem hiding this comment.
Good call, didn't think about that. I'm generally hesitant to use assignment with arrays, but since the index is coming from .findIndex() it should be good, and I agree that it will be easier to read.
There was a problem hiding this comment.
Welp, actually, since indexPatterns.fields is an indexed array assignment doesn't work 😬
|
@spalger I'm focusing on the cross cluster search PRs atm, you may wanna assign this to someone else if you'd like it reviewed in parallel otherwise it'll take me a couple few days to get to it. |
|
@Bargs no worries, it's super small. I'm good with a single reviewer. |
spalger
force-pushed
the
fix/update-field-in-place
branch
from
8131fc3
to
52eb84c
Compare
spalger
added a commit
that referenced
this pull request
May 24, 2017
(cherry picked from commit df2fb14)
|
5.5/5.x: fe5abb2 |
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving updates to a field in an index pattern the field is currently moved to the bottom of the field list, this change causes the field to be replaced in-place instead.