Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): use internal pkg_npm on @kbn/babel-preset #120123

Merged

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 1, 2021

This PR is a step forward on #104519

It changes the package build to use the internal macro for pkg_npm

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Dec 1, 2021
@mistic mistic requested a review from jbudz December 1, 2021 16:00
@mistic mistic marked this pull request as ready for review December 1, 2021 17:05
@mistic mistic requested review from a team as code owners December 1, 2021 17:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 4466130 into elastic:main Dec 2, 2021
@mistic
Copy link
Member Author

mistic commented Dec 2, 2021

That was just a change on the packages build rules, so I will go ahead and merge it.

@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
8.0 Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 120123

mistic added a commit to mistic/kibana that referenced this pull request Dec 2, 2021
# Conflicts:
#	packages/kbn-react-field/BUILD.bazel
mistic added a commit that referenced this pull request Dec 2, 2021
# Conflicts:
#	packages/kbn-react-field/BUILD.bazel
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants