[Vega] Add Filter custom label for kibanaAddFilter #124498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
bhavyarm
added
Feature:Vega
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
|
@elasticmachine merge upstream |
|
Buildkite, test this |
|
@elasticmachine merge upstream |
|
Buildkite, test this |
flash1293
approved these changes
Feb 7, 2022
|
@elasticmachine run elasticsearch-ci/docs |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @alexwizp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vega 'kibanaAddFilter' allows to add Elastic Query DSL and index. The implementation buildQueryFilter takes in third parameter to set a custom label in 'Add Filter'. At the moment, kibanaAddFilter can only take query and index. This PR adds in the third 'alias' parameter to set the custom label from Vega
buildQueryFilter = (query: QueryStringFilter['query'], index: string, alias: string)Below image is self explanatory. The first filter in the image is without custom label (ugly in my opinion), and the second filter is with custom label set in Vega.