[kbn/es] add support for --ready-timeout #126217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
fix/kbn-es/add-startup-timeout
branch
2 times, most recently
from
27715d4
to
9120332
Compare
spalger
force-pushed
the
fix/kbn-es/add-startup-timeout
branch
from
9120332
to
7179bfa
Compare
spalger
added
auto-backport
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
reviewed
Feb 24, 2022
added 2 commits
February 24, 2022 21:12
jbudz
approved these changes
Feb 24, 2022
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2022
(cherry picked from commit a16c20b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2022
(cherry picked from commit a16c20b)
💔 Some backports could not be created
How to fixRe-run the backport manually: Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 25, 2022
kibanamachine
added a commit
that referenced
this pull request
Feb 25, 2022
lucasfcosta
pushed a commit
to lucasfcosta/kibana
that referenced
this pull request
Mar 2, 2022
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 3, 2022
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 3, 2022
This was referenced Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been getting reports of kbn/es causing problems for people who are using custom data directories. It seems this is caused by two things:
_autoRetryfunction in theNativeRealmclass wasn't slowing down for subsequent retry attempts and instead always retrying after 1 second, meaning that we would exhaust our 10 retries for cluster state after about 10 seconds.To fix this I moved the ready check out of
NativeRealm(didn't feel like the right place for it, and I had new config to plumb), updated it to respect a timeout, and then addedreadyTimeout/--ready-timeoutandskipReadyCheck/--skip-ready-checkoptions.