Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Observability] Guided setup button on the overview page #128172

Merged
merged 5 commits into from
Mar 23, 2022
Merged

[Unified Observability] Guided setup button on the overview page #128172

merged 5 commits into from
Mar 23, 2022

Conversation

estermv
Copy link
Contributor

@estermv estermv commented Mar 21, 2022 •
edited
Loading

Summary

Closes #127942
Closes #127272

  • Adds a "Guided setup" button to the current overview page that opens a flyout with the Status visualization component:

Screenshot 2022-03-22 at 14 15 46

  • Updates the title and the description of the flyout:

Screenshot 2022-03-22 at 14 15 54

@estermv
Copy link
Contributor Author

estermv commented Mar 22, 2022

@elasticmachine merge upstream

@estermv estermv added release_note:enhancement release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Unified observability v8.2.0 labels Mar 22, 2022
@estermv estermv marked this pull request as ready for review March 22, 2022 13:13
@estermv estermv requested a review from a team as a code owner March 22, 2022 13:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Unified observability)

@estermv estermv requested a review from formgeist March 22, 2022 13:16
formgeist
formgeist reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍 I noticed a few responsive issues with the page header that probably exist today as well but is made more apparent since we add another action.

CleanShot 2022-03-22 at 14 50 02@2x

The page title is wrapping although it should stay and move the actions below the title when there's not enough space.

CleanShot 2022-03-22 at 14 50 14@2x

On even smaller screens the Guided setup action moves in front of the date picker which seems odd to me when we're placing it at the right side in normal viewports.

Edited: I've opened #128345 to track this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 414.8KB 415.9KB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@estermv estermv requested a review from a team March 22, 2022 14:45
afgomez
afgomez approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@estermv estermv merged commit 77034b3 into elastic:main Mar 23, 2022
@estermv estermv deleted the 127942-add-guided-setup-button branch March 23, 2022 08:21
@estermv
Copy link
Contributor Author

estermv commented Mar 23, 2022

Synced offline with @formgeist. We will open a separate issue to address the page title wrapping issues

@estermv estermv removed the release_note:skip Skip the PR/issue when compiling release notes label Mar 23, 2022
@KOTungseth KOTungseth added the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist left review comments

@afgomez afgomez afgomez approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team:Unified observability v8.2.0
Projects
None yet
Milestone
No milestone
7 participants
@estermv @elasticmachine @kibana-ci @afgomez @formgeist @KOTungseth @kibanamachine