Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Log data tables properly #128297

Merged
merged 6 commits into from
Mar 24, 2022
Merged

[Lens] Log data tables properly #128297

merged 6 commits into from
Mar 24, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #127995
Fixes #121063

Log data tables properly in all cases so additional columns do not show up and the region map table is logged correct as well.

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.2.0 labels Mar 22, 2022
@flash1293 flash1293 requested review from a team as code owners March 22, 2022 17:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps changes LGTM
code review, tested in chrome

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs fixed and changes LGTM, I tested in both Lens and Viz Editor. 👍

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a bug for a heatmap, there's no data displayed (somehow there's pagination though):
Screenshot 2022-03-24 at 13 50 14
Before:

Screenshot 2022-03-24 at 13 49 29

After:
Screenshot 2022-03-24 at 13 50 05

Also, not introduced by this PR, but with a default include empty rows setting there's a lot of data user doesn't probably need because it's empty (you can see it in before pic). I wonder if we could do something about it? 🤔

@flash1293
Copy link
Contributor Author

@mbondyra Good catch with the heatmap, should be fixed now.

with a default include empty rows setting there's a lot of data user doesn't probably need because it's empty

Right, I think it's OK though - consistency seems more important to me than empty rows in this table which are probably easy to handle anyway downstream (e.g. Excel). Also for real world data it's probably not that big of a problem (it tends to have way less gaps especially for things the user wants to export)

@mbondyra
Copy link
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

Fixed the annotations case

@mbondyra
Copy link
Contributor

All works as expected, approved 🆗

@flash1293 flash1293 enabled auto-merge (squash) March 24, 2022 16:08
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 784 783 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
visualizations 340 342 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +204.0B
maps 2.5MB 2.5MB +5.0B
total +209.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionGauge 13.6KB 13.6KB +3.0B
expressionHeatmap 13.8KB 13.8KB -8.0B
expressionMetricVis 8.4KB 8.4KB +3.0B
expressionPartitionVis 21.9KB 21.9KB +12.0B
expressionTagcloud 8.3KB 8.3KB +3.0B
lens 44.9KB 45.4KB +588.0B
maps 68.4KB 69.0KB +611.0B
visualizations 45.7KB 45.8KB +43.0B
total +1.2KB
Unknown metric groups

API count

id before after diff
visualizations 361 363 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
7 participants