[ML] Fixes outlier detection results exploration color legend display. #129058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui (:ml) |
...analytics/pages/analytics_exploration/components/outlier_exploration/outlier_exploration.tsx
Outdated
Show resolved
Hide resolved
...on/data_frame_analytics/pages/analytics_exploration/components/outlier_exploration/common.ts
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
peteharverson
approved these changes
Apr 1, 2022
walterra
added
the
auto-backport
kibanamachine
pushed a commit
that referenced
this pull request
Apr 1, 2022
…color legend display. (#129058) Fixes the display of the color legend for the outlier results table. The check to display the legend was based on just checking if the first row on display had feature influence information. However, depending on the jobs results, not every row might be populated with feature influence information. This PR fixes it by displaying the color legend in any case when feature influence calculation is enabled and calculating the necessary featureCount value by looking at all available rows instead of just the first row. Unit tests have been added for the getFeatureCount() function. (cherry picked from commit 2c9d607)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 1, 2022
…color legend display. (#129058) (#129222) Fixes the display of the color legend for the outlier results table. The check to display the legend was based on just checking if the first row on display had feature influence information. However, depending on the jobs results, not every row might be populated with feature influence information. This PR fixes it by displaying the color legend in any case when feature influence calculation is enabled and calculating the necessary featureCount value by looking at all available rows instead of just the first row. Unit tests have been added for the getFeatureCount() function. (cherry picked from commit 2c9d607) Co-authored-by: Walter Rafelsberger <walter@elastic.co>
lcawl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #127119.
Fixes the display of the color legend for the outlier results table. The check to display the legend was based on just checking if the first row on display had feature influence information. However, depending on the jobs results, not every row might be populated with feature influence information. This PR fixes it by displaying the color legend in any case when feature influence calculation is enabled and calculating the necessary
featureCountvalue by looking at all available rows instead of just the first row. Unit tests have been added for thegetFeatureCount()function.Checklist