[Unified search] Use the DataViews service #130008

nlatipov · 2022-04-12T13:13:57Z

Summary

Motivation:
After PR #127651 is merged, next step will be cleanup of the deprecated IndexPattern service and the use of the DataViews to the Unified Search Plugin. No extra functionality is going to be added.

What was done:

IndexPattern type has been replaced to DataView type inside the unified search plugin, where it was possible without major changes in other plugins;
Imports for deprecated methods and type from data plugin has been changed to @kbn/es-query (Filter, FILTERS, KueryNode );

For a complete cleanup of the deprecated service should perform the following in other plugins #131292.

src/plugins/unified_search/public/services.ts

src/plugins/unified_search/public/typeahead/index.tsx

x-pack/plugins/apm/public/components/shared/kuery_bar/index.tsx

alexwizp · 2022-04-26T11:37:51Z

.../services/drilldowns/embeddable_to_dashboard_drilldown/embeddable_to_dashboard_drilldown.tsx

 } from '@kbn/data-plugin/public';
+import { extractTimeRange } from '@kbn/unified-search-plugin/public';


not sure that extractTimeRange should be part of static contract of unified-search-plugin. I vote for duplicating

extractTimeRange uses extractTimeFilter internally, which I moved to unified search to get rid of deprecated methods. If I make a copy in the extractTimeRange plugin Date, then extractTimeFilter will also need to be returned there. and add it back as a deprecated method. Is it right?

@ppisljar What do you think about moving extractTimeRange and extractTimeFilter into kbn-es-query package? Or we should refactor that somehow? I just see some plugins still use that methods and it's definitely not right to move it into unified-search-plugin

cc @lukasolson i agree unified search plugin is not the right place for this and that moving to a package probably makes sense

x-pack/plugins/infra/public/containers/with_kuery_autocompletion.tsx

elasticmachine · 2022-04-29T07:12:05Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

nlatipov · 2022-04-29T07:18:30Z

@elasticmachine merge upstream

afgomez

Unified observability changes LGTM

crob611

Presentation changes look fine 👍

nlatipov · 2022-05-02T14:18:46Z

@elasticmachine merge upstream

nlatipov · 2022-05-02T15:17:36Z

@elasticmachine merge upstream

nlatipov · 2022-05-16T06:57:31Z

@elasticmachine merge upstream

nlatipov · 2022-05-17T10:30:22Z

@elastic/kibana-app-services we need your 👀 here. Please review

stratoula

I started doing a code review until I realized that something wrong goes off with this PR. There are some components that we have deleted or altered in main (Unified search phase 1 PR). For example I see the saved_query_list_item and saved_query_management that were deleted. Something off with the merge conflicts I suspect.
Can we create a new one from main, just to be sure that it is up to date with the [hase 1 changes or ensure that we are making the changes on the correct code?

src/plugins/unified_search/public/autocomplete/providers/query_suggestion_provider.ts

stratoula · 2022-05-17T10:05:10Z

src/plugins/unified_search/public/actions/apply_filter_action.ts

+import { createAction, IncompatibleActionError } from '@kbn/ui-actions-plugin/public';
+import type { Action } from '@kbn/ui-actions-plugin/public';
+import { FilterManager, TimefilterContract } from '@kbn/data-plugin/public';
+import { esFilters } from '@kbn/data-plugin/public';


Why don't we combine it with the above import?

Yes, sure we can. I separated them because in the future I was going to replace the deprecated esFilters. And in the issue I described why I could not solve this issue in this PR

src/plugins/unified_search/public/autocomplete/providers/kql_query_suggestion/field.tsx

src/plugins/unified_search/public/autocomplete/providers/kql_query_suggestion/value.ts

stratoula · 2022-05-17T10:16:03Z

src/plugins/unified_search/public/data_view_select/create_data_view_select.tsx

@@ -8,12 +8,12 @@

 import React from 'react';

-import { IndexPatternsContract } from '@kbn/data-plugin/public';
-import { IndexPatternSelect, IndexPatternSelectProps } from '.';
+import type { DataViewsContract } from '@kbn/data-plugin/public';


Let's fetch the contract from the dataViews plugin '@kbn/data-views-plugin/public'

Yes, sure. You are right. I'll check where else you can change the imports from @kbn/data-plugin/public to @kbn/data-views-plugin/public

src/plugins/unified_search/public/filter_bar/filter_editor/index.tsx

stratoula · 2022-05-17T10:19:49Z

src/plugins/unified_search/public/filter_bar/filter_editor/index.tsx

-              id: 'unifiedSearch.filter.filterBar.indexPatternSelectPlaceholder',
-              defaultMessage: 'Select a data view',
+              id: 'unifiedSearch.filter.filterBar.dataViewSelectPlaceholder',
+              defaultMessage: 'Select an index pattern',


Same question here

stratoula · 2022-05-17T10:26:30Z

src/plugins/unified_search/public/filter_bar/filter_options.tsx

@@ -0,0 +1,175 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one


Is this file needed? 🤔 I don't see the FilterOptions to be used anywhere.

stratoula · 2022-05-17T10:29:21Z

src/plugins/unified_search/public/query_string_input/filter_editor_wrapper.tsx

@@ -15,7 +15,7 @@ import { IDataPluginServices } from '@kbn/data-plugin/public';
 import type { DataView } from '@kbn/data-views-plugin/public';
 import { FILTER_EDITOR_WIDTH } from '../filter_bar/filter_item/filter_item';
 import { FilterEditor } from '../filter_bar/filter_editor';
-import { fetchIndexPatterns } from './fetch_index_patterns';
+import { fetchDataViews as fetchIndexPatterns } from './fetch_data_views';


Why are we renaming it to fetchIndexPatterns and don't use fetchDataviews instead?

stratoula · 2022-05-17T10:30:47Z

src/plugins/unified_search/public/plugin.ts

-import { PluginInitializerContext, CoreSetup, CoreStart, Plugin } from '@kbn/core/public';
-import { Storage, IStorageWrapper } from '@kbn/kibana-utils-plugin/public';
+
+import './index.scss';


Is this imported twice?

…n this PR

nlatipov · 2022-05-18T07:11:16Z

@elasticmachine merge upstream

nlatipov · 2022-05-20T08:22:03Z

@elasticmachine merge upstream

nlatipov · 2022-05-23T04:51:27Z

@elasticmachine merge upstream

kibana-ci · 2022-05-23T05:49:39Z

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`unifiedSearch`	265	52	-213

Unreferenced deprecated APIs

id	before	after	diff
`data`	57	62	+5

History

💚 Build #46341 succeeded 488f76b
💚 Build #45607 succeeded 613ea83
💔 Build #45594 failed 316d960
💚 Build #45535 succeeded 9c13c0f
💚 Build #45508 succeeded 1572e5d
💚 Build #45380 succeeded a7aab00

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nlatipov

ppisljar

code LGTM

stratoula

Changes LGTM, I also did a brief testing locally in Chrome to ensure that everything works fine.

@example

commit bdb4966 Author: Angela Chuang <6295984+angorayc@users.noreply.github.com> Date: Mon May 23 13:13:23 2022 +0100 styling (elastic#132539) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit a807c90 Author: Esteban Beltran <academo@users.noreply.github.com> Date: Mon May 23 13:36:00 2022 +0200 [Cases] Add a key to userActionMarkdown to prevent stale state (elastic#132681) commit ba84602 Author: Tomasz Ciecierski <ciecierskitomek@gmail.com> Date: Mon May 23 13:33:20 2022 +0200 [Osquery] Change prebuilt saved queries to include prebuilt flag (elastic#132651) commit 6b846af Author: Faisal Kanout <faisal.kanout@elastic.co> Date: Mon May 23 14:11:04 2022 +0300 [Actionable Observability] Update the Rule details design and clean up (elastic#132616) * Add rule status in the rule summary * Match design * Remove unused imports * code review commit c993ff2 Author: Byron Hulcher <byron.hulcher@elastic.co> Date: Mon May 23 06:25:17 2022 -0400 [Workplace Search] Add categories to source data for internal connectors (elastic#132671) commit b59fb97 Author: Pablo Machado <pablo.nevesmachado@elastic.co> Date: Mon May 23 12:02:43 2022 +0200 [Security Solution] Update use_url_state to work with new side nav (elastic#132518) * Fix landing pages browser tab title * Fix new navigation url state * Fix unit tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 693b3e8 Author: Tomasz Ciecierski <ciecierskitomek@gmail.com> Date: Mon May 23 11:54:29 2022 +0200 [Osquery] Add Osquery to Alert context menu (elastic#131790) commit 2cddced Author: Jordan <51442161+JordanSh@users.noreply.github.com> Date: Mon May 23 12:50:55 2022 +0300 [Cloud Posture] Trendline query changes (elastic#132680) commit 7591fb6 Author: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co> Date: Mon May 23 10:37:03 2022 +0100 Fix agent config indicator when applied through fleet integration (elastic#131820) * Fix agent config indicator when applied through fleet integration * Add synthrace scenario Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 37d40d7 Author: Dominique Clarke <dominique.clarke@elastic.co> Date: Mon May 23 04:56:34 2022 -0400 [Synthetics] fix browser type as default in monitor management (elastic#132572) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit ae8b6c8 Author: Lucas F. da Costa <lucas.costa@elastic.co> Date: Mon May 23 09:29:11 2022 +0100 [Uptime] Fix bug causing all monitors to be saved to all locations [solves elastic#132314] (elastic#132325) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit e0944d1 Author: Nodir Latipov <nodir.latypov@gmail.com> Date: Mon May 23 13:27:24 2022 +0500 [Unified search] Use the DataViews service (elastic#130008) * feat: cleanup deprecated service and type * fix: rollback test * refact: replace deprecated type * refact: changed deprecation type * feat: added comments to deprecated imports that can't be cleaned up in this PR * refact: rollback query_string_input.test file commit a3646eb Author: Pablo Machado <machadoum@gmail.com> Date: Mon May 23 10:17:12 2022 +0200 [Security Solutions] Refactor breadcrumbs to support new menu structure (elastic#131624) * Refactor breadcrumbs to support new structure * Fix code style * Fix more code style * Fix unit test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 9649307 Author: István Zoltán Szabó <istvan.szabo@elastic.co> Date: Mon May 23 10:12:54 2022 +0200 [DOCS] Updates alerting authorization docs with info on retaining API keys (elastic#132402) Co-authored-by: Lisa Cawley <lcawley@elastic.co> commit 40df1f3 Author: Tomasz Ciecierski <ciecierskitomek@gmail.com> Date: Mon May 23 08:45:50 2022 +0200 [Osquery] Add labels, move osquery schema link (elastic#132584) commit fbaf058 Author: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com> Date: Sun May 22 17:14:23 2022 -0700 [RAM] Add shareable rules list (elastic#132437) * Shareable rules list * Hide snooze panel in rules list * Address comments and added tests * Fix tests * Fix tests * Fix lint * Address design comments and fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 383239e Author: Kfir Peled <61654899+kfirpeled@users.noreply.github.com> Date: Sun May 22 13:18:42 2022 +0300 [Cloud Posture] Findings - Group by resource - Fixed bug not showing results (elastic#132529) commit fb1eeb0 Author: Georgii Gorbachev <georgii.gorbachev@elastic.co> Date: Sat May 21 00:21:53 2022 +0200 [Security Solution][Detections] Add new fields to the rule model: Related Integrations, Required Fields, and Setup (elastic#132409) **Addresses partially:** elastic/security-team#2083, elastic/security-team#558, elastic/security-team#2856, elastic/security-team#1801 (internal tickets) ## Summary **TL;DR:** With this PR, it's now possible to specify `related_integrations`, `required_fields`, and `setup` fields in prebuilt rules in https://github.com/elastic/detection-rules. They are returned within rules in the API responses. This PR: - Adds 3 new fields to the model of Security detection rules. These fields are common to all of the rule types we have. - **Related Integrations**. It's a list of Fleet integrations associated with a given rule. It's assumed that if the user installs them, the rule might start to work properly because it will start receiving source events potentially matching the rule's query. - **Required Fields**. It's a list of event fields that must be present in the source indices of a given rule. - **Setup Guide**. It's any instructions for the user for setting up their environment in order to start receiving source events for a given rule. It's a text. Markdown is supported. It's similar to the Investigation Guide that we show on the Details page. - Adjusts API endpoints accordingly: - These fields are for prebuilt rules only and are supposed to be read-only in the UI. - Specifying these fields in the request parameters of the create/update/patch rule API endpoints is not supported. - These fields are returned in all responses that contain rules. If they are missing in a rule, default values are returned (empty array, empty string). - When duplicating a prebuilt rule, these fields are being reset to their default value (empty array, empty string). - Export/Import is supported. Edge case / supported hack: it's possible to specify these fields manually in a ndjson doc and import with a rule. - The fields are being copied to `kibana.alert.rule.parameters` field of an alert document, which is mapped as a flattened field type. No special handling for the new fields was needed there. - Adjusts tests accordingly. ## Related Integrations Example (part of a rule returned from the API): ```json { "related_integrations": [ { "package": "windows", "version": "1.5.x" }, { "package": "azure", "integration": "activitylogs", "version": "~1.1.6" } ], } ``` Schema: ```ts /** * Related integration is a potential dependency of a rule. It's assumed that if the user installs * one of the related integrations of a rule, the rule might start to work properly because it will * have source events (generated by this integration) potentially matching the rule's query. * * NOTE: Proper work is not guaranteed, because a related integration, if installed, can be * configured differently or generate data that is not necessarily relevant for this rule. * * Related integration is a combination of a Fleet package and (optionally) one of the * package's "integrations" that this package contains. It is represented by 3 properties: * * - `package`: name of the package (required, unique id) * - `version`: version of the package (required, semver-compatible) * - `integration`: name of the integration of this package (optional, id within the package) * * There are Fleet packages like `windows` that contain only one integration; in this case, * `integration` should be unspecified. There are also packages like `aws` and `azure` that contain * several integrations; in this case, `integration` should be specified. * * @example * const x: RelatedIntegration = { * package: 'windows', * version: '1.5.x', * }; * * @example * const x: RelatedIntegration = { * package: 'azure', * version: '~1.1.6', * integration: 'activitylogs', * }; */ export type RelatedIntegration = t.TypeOf<typeof RelatedIntegration>; export const RelatedIntegration = t.exact( t.intersection([ t.type({ package: NonEmptyString, version: NonEmptyString, }), t.partial({ integration: NonEmptyString, }), ]) ); ``` ## Required Fields Example (part of a rule returned from the API): ```json { "required_fields": [ { "name": "event.action", "type": "keyword", "ecs": true }, { "name": "event.code", "type": "keyword", "ecs": true }, { "name": "winlog.event_data.AttributeLDAPDisplayName", "type": "keyword", "ecs": false } ], } ``` Schema: ```ts /** * Almost all types of Security rules check source event documents for a match to some kind of * query or filter. If a document has certain field with certain values, then it's a match and * the rule will generate an alert. * * Required field is an event field that must be present in the source indices of a given rule. * * @example * const standardEcsField: RequiredField = { * name: 'event.action', * type: 'keyword', * ecs: true, * }; * * @example * const nonEcsField: RequiredField = { * name: 'winlog.event_data.AttributeLDAPDisplayName', * type: 'keyword', * ecs: false, * }; */ export type RequiredField = t.TypeOf<typeof RequiredField>; export const RequiredField = t.exact( t.type({ name: NonEmptyString, type: NonEmptyString, ecs: t.boolean, }) ); ``` ## Setup Guide Example (part of a rule returned from the API): ```json { "setup": "## Config\n\nThe 'PowerShell Script Block Logging' logging policy must be enabled.\nSteps to implement the logging policy with with Advanced Audit Configuration:\n\n```\nComputer Configuration > \nAdministrative Templates > \nWindows PowerShell > \nTurn on PowerShell Script Block Logging (Enable)\n```\n\nSteps to implement the logging policy via registry:\n\n```\nreg add \"hklm\\SOFTWARE\\Policies\\Microsoft\\Windows\\PowerShell\\ScriptBlockLogging\" /v EnableScriptBlockLogging /t REG_DWORD /d 1\n```\n", } ``` Schema: ```ts /** * Any instructions for the user for setting up their environment in order to start receiving * source events for a given rule. * * It's a multiline text. Markdown is supported. */ export type SetupGuide = t.TypeOf<typeof SetupGuide>; export const SetupGuide = t.string; ``` ## Details on the schema This PR adjusts all the 6 rule schemas we have: 1. Alerting Framework rule `params` schema: - `security_solution/server/lib/detection_engine/schemas/rule_schemas.ts` - `security_solution/server/lib/detection_engine/schemas/rule_converters.ts` 2. HTTP API main old schema: - `security_solution/common/detection_engine/schemas/response/rules_schema.ts` 3. HTTP API main new schema: - `security_solution/common/detection_engine/schemas/request/rule_schemas.ts` 4. Prebuilt rule schema: - `security_solution/common/detection_engine/schemas/request/add_prepackaged_rules_schema.ts` 5. Import rule schema: - `security_solution/common/detection_engine/schemas/request/import_rules_schema.ts` 6. Rule schema used on the frontend side: - `security_solution/public/detections/containers/detection_engine/rules/types.ts` Names of the fields on the HTTP API level: - `related_integrations` - `required_fields` - `setup` Names of the fields on the Alerting Framework level: - `params.relatedIntegrations` - `params.requiredFields` - `params.setup` ## Next steps - Create a new endpoint for returning installed Fleet integrations (gonna be a separate PR). - Rebase elastic#131475 on top of this PR after merge. - Cover the new fields with dedicated tests (gonna be a separate PR). - Update API docs (gonna be a separate PR). - Address the tech debt of having 6 different schemas (gonna create a ticket for that). ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios commit 788dd2e Author: Andrew Goldstein <andrew-goldstein@users.noreply.github.com> Date: Fri May 20 16:02:05 2022 -0600 [Security Solution] Fixes sorting and tooltips on columns for non-ECS fields that are only one level deep (elastic#132570) ## [Security Solution] Fixes sorting and tooltips on columns for non-ECS fields that are only one level deep This PR fixes <elastic#132490>, an issue where Timeline columns for non-ECS fields that are only one level deep couldn't be sorted, and displayed incomplete metadata in the column's tooltip. ### Before ![test_field_1_actual_tooltip](https://user-images.githubusercontent.com/4459398/169208299-51d9296a-15e1-4eb0-bc31-a0df6a63f0c5.png) _Before: The column is **not** sortable, and the tooltip displays incomplete metadata_ ### After ![after](https://user-images.githubusercontent.com/4459398/169414767-7274a795-015f-4805-8c3f-b233ead994ea.png) _After: The column is sortable, and the tooltip displays the expected metadata_ ### Desk testing See the _Steps to reproduce_ section of <elastic#132490> for testing details. commit 51ae020 Author: Constance <constancecchen@users.noreply.github.com> Date: Fri May 20 14:30:36 2022 -0700 Upgrade EUI to v55.1.3 (elastic#132451) * Upgrade EUI to 55.1.3 backport * [Deprecation] Remove `watchedItemProps` from EuiContextMenu usage - should no longer be necessary * Update snapshots with new data-popover attr * Fix failing FTR test - Now that EuiContextMenu focus is restored correctly, there is a tooltip around the popover toggle that's blocking an above item that the test wants to click - swapping the order so that the tooltip does not block the clicked item should work * Fix 2nd maps FTR test with blocking tooltip Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 642290b Author: Nathan Reese <reese.nathan@elastic.co> Date: Fri May 20 15:11:15 2022 -0600 [maps] convert ESPewPewSource to typescript (elastic#132656) * [maps] convert ESPewPewSource to typescript * move @ts-expect-error moved by fix commit eb6a061 Author: Brian Seeders <brian.seeders@elastic.co> Date: Fri May 20 16:57:49 2022 -0400 [docs] Add 'yarn dev-docs' for managing and starting dev docs (elastic#132647) commit e0ea600 Author: Hannah Mudge <Heenawter@users.noreply.github.com> Date: Fri May 20 14:55:31 2022 -0600 Add group 6 to FTR config (elastic#132655) commit 41635e2 Author: Karl Godard <karl.godard@elastic.co> Date: Fri May 20 13:35:30 2022 -0700 fixed search highlighting. was only showing highlighted text w/o context (elastic#132650) Co-authored-by: mitodrummer <karlgodard@elastic.co> commit 791ebfa Author: debadair <debadair@elastic.co> Date: Fri May 20 13:34:04 2022 -0700 [DOCS] Remove obsolete license expiration info (elastic#131474) * [DOCS] Remove obsolete license expiration info As of elastic/elasticsearch#79671, Elasticsearch does a more stringent license check rather than operating in a semi-degraded mode. Closes elastic#127845 Closes elastic#125702 * Update docs/management/managing-licenses.asciidoc Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit e55bf40 Author: Nathan Reese <reese.nathan@elastic.co> Date: Fri May 20 14:15:00 2022 -0600 [Maps] create MVT_VECTOR when using choropleth wizard (elastic#132648) commit 46cd729 Author: Jan Monschke <jan.monschke@elastic.co> Date: Fri May 20 22:02:00 2022 +0200 [SecuritySolution] Disable agent status filters and timeline interaction (elastic#132586) * fix: disable drag-ability and hover actions for agent statuses The agent fields cannot be queried with ECS and therefore should not provide Filter In/Out functionality nor should users be able to add their representative fields to timeline investigations. Therefore users should not be able to add them to a timeline query by dragging them. * chore: make code more readable commit e857b30 Author: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com> Date: Fri May 20 20:36:59 2022 +0200 remove human-readable automatic slug generation (elastic#132593) * remove human-readable automatic slug generation * make change non-breaking * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * remove test Co-authored-by: streamich <streamich@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> commit 6fc2fff Author: Lisa Cawley <lcawley@elastic.co> Date: Fri May 20 10:48:15 2022 -0700 [ML] Minor edits in prebuilt job descriptions (elastic#132633) commit ecca231 Author: Felix Stürmer <weltenwort@users.noreply.github.com> Date: Fri May 20 19:37:03 2022 +0200 [Stack Monitoring] Convert setup routes to TypeScript (elastic#131265) commit 065ea3e Author: Byron Hulcher <byron.hulcher@elastic.co> Date: Fri May 20 13:12:49 2022 -0400 [Workplace Search] Remove Custom API Source Integration tile (elastic#132538) commit 583d2b7 Author: Byron Hulcher <byron.hulcher@elastic.co> Date: Fri May 20 13:12:32 2022 -0400 [Workplace Search] Add documentation links for v8.3.0 connectors (elastic#132547) commit c244883 Author: Nathan Reese <reese.nathan@elastic.co> Date: Fri May 20 10:35:00 2022 -0600 [maps] show marker size in legend (elastic#132549) * [Maps] size legend * clean-up * refine spacing * clean up * more cleanup * use euiTheme for colors * fix jest test * do not show marker sizes for icons * remove lodash Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit d70ae0f Author: Quynh Nguyen <43350163+qn895@users.noreply.github.com> Date: Fri May 20 11:34:35 2022 -0500 [ILM] Add warnings for managed system policies (elastic#132269) * Add warnings to system/managed policies * Fix translations, policies * Add jest tests * Add jest tests to assert new toggle behavior * Add jest tests for edit policy callout * Fix snapshot * [ML] Update jest tests with helper, rename helper for clarity * [ML] Add hook for local storage to remember toggle setting * [ML] Fix naming Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit f70b4af Author: Nicolas Chaulet <nicolas.chaulet@elastic.co> Date: Fri May 20 12:22:08 2022 -0400 [Fleet] Fix rolling upgrade CANCEL and UI fixes (elastic#132625) commit d9f141a Author: Kevin Logan <56395104+kevinlog@users.noreply.github.com> Date: Fri May 20 11:37:35 2022 -0400 [Security Solution] Telemetry for Event Filters counts on both user and global entries (elastic#132542) commit 1b4ac7d Author: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com> Date: Fri May 20 17:54:13 2022 +0300 [XY] Reference lines overlay fix. (elastic#132607) commit 759f13f Author: Nicolas Chaulet <nicolas.chaulet@elastic.co> Date: Fri May 20 10:39:09 2022 -0400 [Fleet] Remove reference to non removable package feature (elastic#132458) commit 7e15097 Author: Lisa Cawley <lcawley@elastic.co> Date: Fri May 20 07:32:27 2022 -0700 [ML] Adds placeholder text for testing NLP models (elastic#132486) commit bc31053 Author: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com> Date: Fri May 20 17:09:20 2022 +0300 [Discover][Alerting] Implement editing of dataView, query & filters (elastic#131688) * [Discover] introduce params editing using unified search * [Discover] fix unit tests * [Discover] fix functional tests * [Discover] fix unit tests * [Discover] return test subject name * [Discover] fix alert functional test * Update x-pack/plugins/stack_alerts/public/alert_types/es_query/expression/search_source_expression_form.tsx Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com> * Update x-pack/plugins/stack_alerts/public/alert_types/es_query/expression/search_source_expression_form.tsx Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> * [Discover] hide filter panel options * [Discover] improve functional test * [Discover] apply suggestions * [Discover] change data view selector * [Discover] fix tests * [Discover] apply suggestions, fix lang mode toggler * [Discover] mote interface to types file, clean up diff * [Discover] fix saved query issue * Update x-pack/plugins/stack_alerts/server/alert_types/es_query/alert_type.ts Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> * [Discover] remove zIndex * [Discover] omit null searchType from esQuery completely, add isEsQueryAlert check for useSavedObjectReferences hook * [Discover] set searchType to esQuery when needed * [Discover] fix unit tests * Update x-pack/plugins/stack_alerts/server/alert_types/es_query/alert_type_params.ts Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> * Update x-pack/plugins/stack_alerts/server/alert_types/es_query/alert_type.ts Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com> Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> commit d344088 Author: Nathan Reese <reese.nathan@elastic.co> Date: Fri May 20 08:06:25 2022 -0600 [maps] Use label features from ES vector tile search API to fix multiple labels (elastic#132080) * [maps] mvt labels * eslint * only request labels when needed * update vector tile integration tests for hasLabels parameter * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * fix tests * fix test * only add _mvt_label_position filter when vector tiles are from ES vector tile search API * review feedback * include hasLabels in source data * fix jest test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 1d8bc7e Author: Shivindera Singh <shivindera@gmail.com> Date: Fri May 20 15:53:00 2022 +0200 hasData service - hit search api in case of an error with resolve api (elastic#132618) commit 7c37eda Author: Tomasz Ciecierski <ciecierskitomek@gmail.com> Date: Fri May 20 15:42:28 2022 +0200 [Osquery] Fix pagination issue on Alert's Osquery Flyout (elastic#132611) commit 2e51140 Author: Katerina Patticha <aikaterini.patticha@elastic.co> Date: Fri May 20 15:34:29 2022 +0200 Show service group icon only when there are service groups (elastic#131138) * Show service group icon when there are service groups * Fix fix errors * Remove additional request and display icon only for the service groups * Revert "Remove additional request and display icon only for the service groups" This reverts commit 7ff2bc9. * Add dependencies Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 24cbb32 Author: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com> Date: Fri May 20 16:27:14 2022 +0300 [XY] `pointsRadius`, `showPoints` and `lineWidth`. (elastic#130391) * Added pointsRadius, showPoints and lineWidth. * Added tests. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 1c2eb9f Author: Sergi Massaneda <sergi.massaneda@elastic.co> Date: Fri May 20 13:59:56 2022 +0100 [Security Solution] New Side nav integrating links config (elastic#132210) * Update navigation landing pages to use appLinks config * align app links changes * link configs refactor to use updater$ * navigation panel categories * test and type fixes * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * types changes * shared style change moved to a separate PR * use old deep links * minor changes after ux meeting * add links filtering * remove duplicated categories * temporary increase of plugin size limit * swap management links order * improve performance closing nav panel * test updated * host isolation page filterd and some improvements * remove async from plugin start * move links register from start to mount * restore size limits * Fix use_show_timeline unit tests Co-authored-by: Pablo Neves Machado <pablo.nevesmachado@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> commit 92ac7f9 Author: Katrin Freihofner <katrin.freihofner@elastic.co> Date: Fri May 20 13:51:51 2022 +0200 adds small styling updates to header panels (elastic#132596)

* feat: cleanup deprecated service and type * fix: rollback test * refact: replace deprecated type * refact: changed deprecation type * feat: added comments to deprecated imports that can't be cleaned up in this PR * refact: rollback query_string_input.test file

nlatipov force-pushed the issue-change-index-pattern-to-data-view branch from 27a37af to c1f0e57 Compare April 25, 2022 06:56

nlatipov changed the title ~~Issue change index pattern to data view~~ [Unified search] Use the DataViews service Apr 25, 2022

nlatipov force-pushed the issue-change-index-pattern-to-data-view branch from e67b79a to 6f35ee3 Compare April 25, 2022 08:53

alexwizp reviewed Apr 26, 2022

View reviewed changes

src/plugins/unified_search/public/services.ts Outdated Show resolved Hide resolved

alexwizp reviewed Apr 26, 2022

View reviewed changes

src/plugins/unified_search/public/typeahead/index.tsx Outdated Show resolved Hide resolved

alexwizp reviewed Apr 26, 2022

View reviewed changes

x-pack/plugins/apm/public/components/shared/kuery_bar/index.tsx Outdated Show resolved Hide resolved

alexwizp reviewed Apr 26, 2022

View reviewed changes

x-pack/plugins/infra/public/containers/with_kuery_autocompletion.tsx Outdated Show resolved Hide resolved

nlatipov force-pushed the issue-change-index-pattern-to-data-view branch from e661a82 to 2ba6188 Compare April 27, 2022 12:10

elastic deleted a comment from kibana-ci Apr 27, 2022

nlatipov force-pushed the issue-change-index-pattern-to-data-view branch from 892072f to 85c1529 Compare April 28, 2022 18:52

nlatipov self-assigned this Apr 28, 2022

nlatipov requested a review from stratoula April 28, 2022 19:33

nlatipov added backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Unified search Unified search related tasks v8.3.0 labels Apr 28, 2022

elastic deleted a comment from kibanamachine Apr 28, 2022

nlatipov marked this pull request as ready for review April 29, 2022 07:12

nlatipov requested review from a team as code owners April 29, 2022 07:12

nlatipov mentioned this pull request May 1, 2022

[Unified Search] Replacement deprecated methods in Unified Search #131292

Closed

afgomez self-requested a review May 2, 2022 14:08

afgomez approved these changes May 2, 2022

View reviewed changes

crob611 approved these changes May 2, 2022

View reviewed changes

nlatipov force-pushed the issue-change-index-pattern-to-data-view branch from c272b86 to 869e66d Compare May 10, 2022 06:59

stratoula requested changes May 17, 2022

View reviewed changes

feat: cleanup deprecated service and type

a7aab00

nlatipov force-pushed the issue-change-index-pattern-to-data-view branch from 9ed624f to a7aab00 Compare May 17, 2022 14:43

nlatipov added 5 commits May 18, 2022 00:34

fix: rollback test

1572e5d

refact: replace deprecated type

e96d35d

refact: changed deprecation type

9c13c0f

feat: added comments to deprecated imports that can't be cleaned up i…

ee6de6c

…n this PR

refact: rollback query_string_input.test file

316d960

Merge branch 'main' into issue-change-index-pattern-to-data-view

613ea83

Merge branch 'main' into issue-change-index-pattern-to-data-view

488f76b

Merge branch 'main' into issue-change-index-pattern-to-data-view

0fafd38

ppisljar approved these changes May 23, 2022

View reviewed changes

stratoula approved these changes May 23, 2022

View reviewed changes

nlatipov merged commit e0944d1 into elastic:main May 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Unified search] Use the DataViews service #130008

[Unified search] Use the DataViews service #130008

nlatipov commented Apr 12, 2022 •

edited

Loading

alexwizp Apr 26, 2022

nlatipov Apr 26, 2022

alexwizp Apr 26, 2022

ppisljar May 23, 2022

elasticmachine commented Apr 29, 2022

nlatipov commented Apr 29, 2022

afgomez left a comment

crob611 left a comment

nlatipov commented May 2, 2022

nlatipov commented May 2, 2022

nlatipov commented May 16, 2022

nlatipov commented May 17, 2022

stratoula left a comment

stratoula May 17, 2022

nlatipov May 17, 2022

stratoula May 17, 2022

nlatipov May 17, 2022

stratoula May 17, 2022

stratoula May 17, 2022

stratoula May 17, 2022

stratoula May 17, 2022

nlatipov commented May 18, 2022

nlatipov commented May 20, 2022

nlatipov commented May 23, 2022

kibana-ci commented May 23, 2022

References to deprecated APIs

Unreferenced deprecated APIs

ppisljar left a comment

stratoula left a comment

		} from '@kbn/data-plugin/public';
		import { extractTimeRange } from '@kbn/unified-search-plugin/public';

		@@ -0,0 +1,175 @@
		/*
		* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one

[Unified search] Use the DataViews service #130008

[Unified search] Use the DataViews service #130008

Conversation

nlatipov commented Apr 12, 2022 • edited Loading

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Apr 29, 2022

nlatipov commented Apr 29, 2022

afgomez left a comment

Choose a reason for hiding this comment

crob611 left a comment

Choose a reason for hiding this comment

nlatipov commented May 2, 2022

nlatipov commented May 2, 2022

nlatipov commented May 16, 2022

nlatipov commented May 17, 2022

stratoula left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nlatipov commented May 18, 2022

nlatipov commented May 20, 2022

nlatipov commented May 23, 2022

kibana-ci commented May 23, 2022

💚 Build Succeeded

Metrics [docs]

References to deprecated APIs

Unreferenced deprecated APIs

History

ppisljar left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

nlatipov commented Apr 12, 2022 •

edited

Loading