Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional spaceId in rules_client #130704

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Fix optional spaceId in rules_client #130704

merged 5 commits into from
Apr 28, 2022

Conversation

ersin-erdal
Copy link
Contributor

@ersin-erdal ersin-erdal commented Apr 20, 2022 •
edited
Loading

fixes: #129458

plugin.spaces in alerting plugin is the spaces plugin itself and there isn't a way to disable it,

spaces_service never returns undefined for spaceId and activeSpace, therefore getSpace and getSpaceId can never return undefined in alerting plugin.

kibana/x-pack/plugins/spaces/server/spaces_service/spaces_service.ts

Line 53 in d0643e0

getSpaceId(request: KibanaRequest): string;

kibana/x-pack/plugins/spaces/server/spaces_service/spaces_service.ts

Line 65 in d0643e0

getActiveSpace(request: KibanaRequest): Promise<Space>;

@ersin-erdal ersin-erdal added release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework v8.3.0 labels Apr 20, 2022
@ersin-erdal ersin-erdal marked this pull request as ready for review April 20, 2022 20:45
@ersin-erdal ersin-erdal requested a review from a team as a code owner April 20, 2022 20:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mikecote
mikecote approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! but I have two nitpicks 👍

x-pack/plugins/alerting/server/plugin.ts Show resolved Hide resolved
x-pack/plugins/alerting/server/plugin.test.ts Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ersin-erdal ersin-erdal merged commit 48ed43d into elastic:main Apr 28, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 28, 2022
@ersin-erdal ersin-erdal deleted the 129458-type-mismatch branch April 28, 2022 13:51
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@ersin-erdal @kertal
Fix optional spaceId in rules_client (elastic#130704)
12b129e 
* Fix optional spaceId in rules_client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@mikecote mikecote mikecote approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type mismatch in alerting task runner
6 participants
@ersin-erdal @elasticmachine @kibana-ci @mikecote @ymao1 @kibanamachine