Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Terms with keyword field with "numbers" is displayed with a weird date #132226

Merged
merged 3 commits into from
May 24, 2022
Merged

[TSVB] Terms with keyword field with "numbers" is displayed with a weird date #132226

merged 3 commits into from
May 24, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 16, 2022 •
edited
Loading

Closes: #132208

Summary

This PR fixes 2 issues:

What was changed:

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp self-assigned this May 19, 2022
@alexwizp alexwizp added v8.3.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix backport:skip This commit does not require backporting labels May 19, 2022
@alexwizp alexwizp marked this pull request as ready for review May 19, 2022 11:21
@alexwizp alexwizp requested review from a team as code owners May 19, 2022 11:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

flash1293
flash1293 reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, not sure about the options for the field formater, but the app services team probably has an opinion on it. Left some nits

src/plugins/vis_types/timeseries/public/application/components/vis_with_splits.js Show resolved Hide resolved
src/plugins/vis_types/timeseries/server/lib/vis_data/response_processors/series/time_shift.js Outdated Show resolved Hide resolved
flash1293
flash1293 approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elastic/kibana-app-services please have a look

stratoula
stratoula approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine! LGTM!

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 300 299 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fieldFormats 247 251 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 465.3KB 464.7KB -604.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fieldFormats 44.4KB 44.4KB +6.0B
Unknown metric groups

API count

id before after diff
fieldFormats 286 290 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

ppisljar
ppisljar approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app servies changes LGTM

@alexwizp alexwizp merged commit b288a94 into elastic:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@ppisljar ppisljar ppisljar approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] Terms with keyword field with "numbers" is displayed with a weird date
7 participants
@alexwizp @elasticmachine @kibana-ci @flash1293 @ppisljar @stratoula @kibanamachine