[Data] Add updated essql expression function

[dokmic]

Summary

Resolves #129478.

Checklist

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

[Dosant]

So canvas now uses a new essql function that uses a new generic strategy from data plugin?
Compared to the new generic strategy, canvas ESSQL_SEARCH_STRATEGY did internal pagination through scroll till the end server-side.
If I understand correctly, then canvas now lost it now, correct?

If yes, then we need to add it back somewhere.

Options I was thinking of:

1. Add it as an option to search strategy and do it internally server-side as it was before (bad because doesn't fit into async search and search polling idea until we support client-side search strategies)
2. Handle it on the expression function level, maybe fit it into the partial results framework

[ppisljar]

what did the scroll achieve that we don't with the new strategy ? canvas on the client received the list of all results. It will get the same now ?

[ppisljar]

canvas has the same behavior, seems they intended to support larger requests at some point but feature newer worked.

we will switch to the new strategy and we can think about supporting larger requests in the future.

[ppisljar]

canvas essql search strategy can be deleted as well

[dokmic]

canvas essql search strategy can be deleted as well

@ppisljar we cannot delete that yet, it is used in the canvas's esdocs function.

[flash1293]

This seems to have the same issue as the canvas essql function - it doesn't respect the count if it's larger than 100. It works fine in dev tools:

GET _sql
{
  "query": """
  SELECT bytes FROM kibana_sample_data_logs
  """,
  "fetch_size": 1000
}

This gives me 1000 rows.

But

essql query="SELECT bytes FROM kibana_sample_data_logs" count=10000 
| render as="debug" 

will give me only 100 rows in Canvas

[ppisljar]

LGTM

[crob611]

@flash1293 that's a strange bug with count. It looks like it only happens when you are doing the render as debug though. If you just do straight render, you'll get a table paginated through the expected number of results.

[crob611]

Presentation changes look good to me. New function works as expected in Canvas.

[dokmic]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 12fc3bb
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
canvas	1128	1126	-2
data	511	513	+2
total			-0

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
data	2874	2875	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
canvas	1.0MB	1.0MB	-1.9KB
controls	426.4KB	426.4KB	+15.0B
dashboard	425.4KB	425.4KB	+15.0B
discover	514.8KB	514.8KB	+15.0B
inputControlVis	77.6KB	77.6KB	+15.0B
unifiedSearch	176.7KB	176.7KB	+15.0B
total			-1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	415.9KB	420.7KB	+4.8KB
securitySolution	249.4KB	249.4KB	+15.0B
total			+4.8KB

Unknown metric groups

API count

id	before	after	diff
data	3489	3491	+2

ESLint disabled line counts

id	before	after	diff
data	58	60	+2

References to deprecated APIs

id	before	after	diff
canvas	67	64	-3
data	384	385	+1
total			-2

Total ESLint disabled count

id	before	after	diff
data	62	64	+2

History

• 💔 Build #47834 failed 5ff0ecb
• 💔 Build #47791 failed c863d0b
• 💔 Build #47684 failed bd2bda1
• 💔 Build #47646 failed e287199
• 💚 Build #45374 succeeded 40aed7f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream