Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Use Observability rule type registry for list of rule types #132484

Conversation

simianhacker
Copy link
Member

Summary

This PR removes the static list of rule types, OBSERVABILITY_RULE_TYPES, by adding a list() method to the observabilityRuleTypeRegistry which returns a dynamic list of rules that are registered with Observability. This will prevent situations where solutions add new rules but they don't show up in the Observability rules manager because the author didn't realize they also needed to update OBSERVABILITY_RULE_TYPES.

@simianhacker simianhacker requested a review from a team as a code owner May 18, 2022 21:58
@simianhacker simianhacker added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 release_note:fix Feature:Observability RAC labels May 18, 2022
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 451.9KB 451.7KB -222.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 92.2KB 92.2KB +30.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mgiota
Copy link
Contributor

mgiota commented May 19, 2022

@simianhacker I tested locally and I verify that only o11y rule types appear in the new o11y rules page
Screenshot 2022-05-19 at 10 01 38

@simianhacker simianhacker merged commit 2cbedcd into elastic:main May 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 19, 2022
@simianhacker simianhacker deleted the use-obs-rule-type-registry-for-list-of-rule-types branch April 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Observability RAC release_note:fix Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants