Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix sorting by size on data streams table #132833

Merged
merged 1 commit into from
May 24, 2022
Merged

[Fleet] Fix sorting by size on data streams table #132833

merged 1 commit into from
May 24, 2022

Conversation

kpollich
Copy link
Member

Summary

Fixes #132825

Use non-formatted size field to sort, but render formatted size group in column.

Screenshots

Ascending sort:

image

Descending sort:

image

@kpollich kpollich added release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 labels May 24, 2022
@kpollich kpollich requested a review from a team as a code owner May 24, 2022 17:00
@kpollich kpollich self-assigned this May 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kpollich kpollich enabled auto-merge (squash) May 24, 2022 17:34
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 722.8KB 722.9KB +67.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit b7aded9 into elastic:main May 24, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@kpollich kpollich

Labels
backport:skip This commit does not require backporting release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Data Streams table's "sort by size" functionality does not work
5 participants
@kpollich @elasticmachine @kibana-ci @nchaulet @kibanamachine