-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Fix axis title visibility bug #134082
Conversation
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! LGTM
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
* 🐛 fix title visibility bug * 🏷️ Fix type issues (cherry picked from commit 342e7a1) # Conflicts: # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
Summary
Fixes #133516
This PR addresses the inconsistency issue with axis title visibility: the bug was due to the classic redux double state update, where the second update was overriding the first state update.
In the specific case the
title
update was overriding thevisibility
one, leading to the bug.The PR refactors the update function to be unique and update both values at once.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers