Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix axis title visibility bug #134082

Merged
merged 4 commits into from
Jun 15, 2022
Merged

[Lens] Fix axis title visibility bug #134082

merged 4 commits into from
Jun 15, 2022

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jun 9, 2022

Summary

Fixes #133516

This PR addresses the inconsistency issue with axis title visibility: the bug was due to the classic redux double state update, where the second update was overriding the first state update.
In the specific case the title update was overriding the visibility one, leading to the bug.

The PR refactors the update function to be unique and update both values at once.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.4.0 v8.3.1 labels Jun 9, 2022
@dej611 dej611 removed the v8.3.1 label Jun 15, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionXY 96.5KB 96.5KB -5.0B
lens 1.2MB 1.2MB +108.0B
total +103.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 marked this pull request as ready for review June 15, 2022 10:22
@dej611 dej611 requested a review from a team as a code owner June 15, 2022 10:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! LGTM

@dej611 dej611 merged commit 342e7a1 into elastic:main Jun 15, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.3 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.3:
- [XY] showTooltip argument. (#130530)

Manual backport

To create the backport manually run:

node scripts/backport --pr 134082

Questions ?

Please refer to the Backport tool documentation

dej611 added a commit to dej611/kibana that referenced this pull request Jun 15, 2022
* 🐛 fix title visibility bug

* 🏷️ Fix type issues

(cherry picked from commit 342e7a1)

# Conflicts:
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
dej611 added a commit that referenced this pull request Jun 15, 2022
* 🐛 fix title visibility bug

* 🏷️ Fix type issues

(cherry picked from commit 342e7a1)

# Conflicts:
#	src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Axis title selection state resets
5 participants