Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Better default for date_range agg #134220

Merged
merged 1 commit into from
Jun 14, 2022
Merged

[Visualize] Better default for date_range agg #134220

merged 1 commit into from
Jun 14, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #134069

by setting the default of the field param to undefined instead of empty string in case the current data view doesn't have a default time field.

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppServicesSv auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.4.0 labels Jun 13, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 424.2KB 424.3KB +92.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review June 13, 2022 15:04
@flash1293 flash1293 requested a review from a team as a code owner June 13, 2022 15:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

mbondyra
mbondyra approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, fixed 🆗

Dosant
Dosant approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@flash1293 flash1293 merged commit 30aff74 into elastic:main Jun 14, 2022
kibanamachine pushed a commit that referenced this pull request Jun 14, 2022
@flash1293
better default (#134220)
cdbf8a7 
(cherry picked from commit 30aff74)
@kibanamachine kibanamachine mentioned this pull request Jun 14, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 14, 2022
@kibanamachine @flash1293
better default (#134220) (#134335)
b5bc4dc 
(cherry picked from commit 30aff74)

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Visualizations] misleading error message for date range on non-time-based data views
6 participants
@flash1293 @kibana-ci @elasticmachine @kibanamachine @mbondyra @Dosant