Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top erroneous transactions #134929

Merged
merged 23 commits into from
Jul 18, 2022
Merged

Top erroneous transactions #134929

merged 23 commits into from
Jul 18, 2022

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Jun 22, 2022 •
edited
Loading

Summary

  • Adds table for top erroneous transactions in errors details page
  • Adds table for top errors in transaction details page
Screen.Recording.2022-07-13.at.14.19.18.mov

Closes #133368 and https://github.com/elastic/apm-dev/issues/767

@gbamparop gbamparop added the Team:APM All issues that need APM UI Team support label Jun 22, 2022
@gbamparop
Copy link
Contributor Author

/oblt-deploy

dgieselaar
dgieselaar reviewed Jun 23, 2022
View reviewed changes
...k/plugins/apm/public/components/app/error_group_details/top_erroneous_transactions/index.tsx Outdated
name: i18n.translate(
'xpack.apm.errorGroupTopTransactions.column.occurrences',
{
defaultMessage: 'Number of transactions affected',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the number of transactions affected or the number of occurrences? (Multiple errors can occur in the scope of a single transaction).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the number of error occurrences for a particular transaction name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the label is incorrect then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right good spot. It should be something like "Occurrences" as in the other error tables.

@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

kibanamachine and others added 17 commits July 5, 2022 05:38
@kibanamachine
Merge branch 'main' into top-erroneous-transactions
2f50b65
@gbamparop
Add API test for top erroneous transactions
3af70a8
@gbamparop
Add e2e test for top erroneous transactions table
40a9634
@gbamparop
Add e2e tests for transaction details page
94ad5d3
@gbamparop
Remove error ratio and filters from top erroneous transactions table
88ee21a
@gbamparop
Add top 5 errors to transaction details page
9ecb484
@gbamparop
Add top errors to a new row on small viewports
7cac7ad
@gbamparop
Change the width of error distribution and top erroneous transactions
e981188
@gbamparop
Rename occurrences column and change the no data message
6e9947c
@gbamparop
Remove the 'View all related errors link'
7d118e7
@gbamparop
Refactor e2e tests
68b0ee4
@gbamparop
Fix API tests for top erroneous transactions
9ca7b58
@gbamparop
Add API test for errorsMainStatisticsByTransactionNameRoute
80aa041
@gbamparop
Merge remote-tracking branch 'upstream/main' into top-erroneous-trans…
b1d3903 
…actions
@gbamparop
Remove errorsDetailedStatisticsByTransactionNameRoute route
64a16bf
@gbamparop
Change e2e tests
8085e4b
@gbamparop
Rename ErrorGroupDetailedStatisticsByTransactionName
fece886
@gbamparop gbamparop added release_note:feature Makes this part of the condensed release notes v8.4.0 backport:skip This commit does not require backporting labels Jul 13, 2022
@gbamparop gbamparop marked this pull request as ready for review July 13, 2022 13:21
@gbamparop gbamparop requested a review from a team as a code owner July 13, 2022 13:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@gbamparop
Copy link
Contributor Author

/oblt-deploy

@cauemarcondes
Copy link
Contributor

Should we use 8 occ. here too? cc @boriskirov

Screen Shot 2022-07-13 at 1 23 58 PM

cauemarcondes
cauemarcondes approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! Added some nit comments.

x-pack/plugins/apm/server/routes/errors/get_error_groups/get_error_group_main_statistics.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/server/routes/errors/route.ts Show resolved Hide resolved
x-pack/plugins/apm/server/routes/errors/route.ts Show resolved Hide resolved
@gbamparop
Copy link
Contributor Author

gbamparop commented Jul 18, 2022 •
edited
Loading

Should we use 8 occ. here too?

@cauemarcondes Added in e07d179

@gbamparop gbamparop enabled auto-merge (squash) July 18, 2022 13:34
@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1302 1304 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +5.4KB
Unknown metric groups

ESLint disabled line counts

id before after diff
apm 86 88 +2

Total ESLint disabled count

id before after diff
apm 100 102 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gbamparop gbamparop merged commit 5c56102 into elastic:main Jul 18, 2022
@gbamparop
Copy link
Contributor Author

/oblt-deploy

@gbamparop gbamparop mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar left review comments

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:APM All issues that need APM UI Team support v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Link to top erroneous transactions
6 participants
@gbamparop @elasticmachine @cauemarcondes @kibana-ci @dgieselaar @kibanamachine