Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Fixes a react minified error when there is a List API error #137415

Conversation

dasansol92
Copy link
Contributor

Summary

Fixes a react minified error when List API returns an error.
An Http error was used as a react node and it was causing the app crashing.
Also, displays a toaster with the reported error by the API

For maintainers

@dasansol92 dasansol92 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.5.0 labels Jul 28, 2022
@dasansol92
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.5MB 5.5MB +232.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dasansol92 dasansol92 marked this pull request as ready for review July 28, 2022 17:15
@dasansol92 dasansol92 requested a review from a team as a code owner July 28, 2022 17:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@dasansol92 dasansol92 requested review from parkiino and removed request for ashokaditya July 28, 2022 17:15
@dasansol92 dasansol92 merged commit 07f532e into elastic:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants