Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Alerting] Ability to bulk update API keys for alerting rules #139036

Merged
merged 6 commits into from
Aug 23, 2022
Merged

[ResponseOps][Alerting] Ability to bulk update API keys for alerting rules #139036

merged 6 commits into from
Aug 23, 2022

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Aug 17, 2022 •
edited
Loading

Resolves #138011

Summary

Allows users to bulk update API keys for alerting rules in the rules table.

Checklist

To verify

  • Select multiple rules and select the Manage rules button
  • Select Update API Keys and verify that the keys are updated properly

@doakalexi doakalexi changed the title Adding bulk update api keys [ResponseOps][Alerting] Ability to bulk update API keys for alerting rules Aug 17, 2022
@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:feature Makes this part of the condensed release notes labels Aug 17, 2022
@doakalexi doakalexi marked this pull request as ready for review August 22, 2022 13:01
@doakalexi doakalexi requested a review from a team as a code owner August 22, 2022 13:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.0MB 1.0MB +644.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ymao1
ymao1 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected.

pmuellr
pmuellr approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected. Check the API key of a rule updated with this gesture, and it changed when complete.

@pmuellr
Copy link
Member

pmuellr commented Aug 22, 2022

@mikecote - I'm curious what our ongoing story with "bulk" editing is. We have a bunch of other "bulk" editing capabilities in x-pack/plugins/alerting/server/routes/bulk_edit_rules.ts, but I'm not sure if this operation should go in there, to keep all the bulk editing together, or if it's not worth having a separate HTTP API for this, and so it's fine as is as UX-gesture only.

Not a blocker for this PR, if we wanted to enable an actual "bulk" update API key API, could be done in a subsequent PR.

@doakalexi doakalexi merged commit 6aa29cb into elastic:main Aug 23, 2022
@kibanamachine kibanamachine added v8.5.0 backport:skip This commit does not require backporting labels Aug 23, 2022
@mikecote
Copy link
Contributor

mikecote commented Aug 23, 2022 •
edited
Loading

@mikecote - I'm curious what our ongoing story with "bulk" editing is. We have a bunch of other "bulk" editing capabilities in x-pack/plugins/alerting/server/routes/bulk_edit_rules.ts, but I'm not sure if this operation should go in there, to keep all the bulk editing together, or if it's not worth having a separate HTTP API for this, and so it's fine as is as UX-gesture only.

Not a blocker for this PR, if we wanted to enable an actual "bulk" update API key API, could be done in a subsequent PR.

@pmuellr Yeah, separate API would make sense from my perspective. We don't call the update API to update the API key, same could be said about the bulk. We should for sure create a follow-up issue for backlog purposes.

@pmuellr
Copy link
Member

pmuellr commented Aug 23, 2022 •
edited
Loading

Created issue move "bulk update API keys" into the "bulk" route #139313 to track that, thx

@pmuellr pmuellr mentioned this pull request Aug 23, 2022
Open
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@doakalexi @Mpdreamz
[ResponseOps][Alerting] Ability to bulk update API keys for alerting …
ce3b6fb 
…rules (elastic#139036)

* Adding bulk update api keys

* Adding tests
@ymao1 ymao1 mentioned this pull request Sep 6, 2022
Merged
@doakalexi doakalexi deleted the alerting/bulk-update-api-keys branch December 6, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:feature Makes this part of the condensed release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to bulk update API keys for alerting rules
7 participants
@doakalexi @elasticmachine @kibana-ci @pmuellr @mikecote @ymao1 @kibanamachine