[drift] Update Drift Storybook to apply context, fix bug #139510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
review
Team:Cloud
loe:small
|
So running on this branch, looks like this resolves the issue with storybook for me, at least on chrome. Firefox fails but that seems to be due to this, still investigating. Safari is still failing and |
lukeelmers
approved these changes
Aug 26, 2022
|
@elasticmachine merge upstream |
clintandrewhall
changed the title
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
claracruz
approved these changes
Aug 30, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Aug 30, 2022
* [drift] Update Drift Storybook to apply context * A few tweaks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit af42246)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Storybook example for Drift chat was lacking the context provider, which in turn provides parameters to Drift chat. This PR fixes that issue, and adds argument fields to configure Drift. It also fixes a bug where Drift may not appear.
The bug
While working on this, I discovered a bug/change that sometimes prevents Drift from being displayed completely. When I wrote this (in #123772), Drift would "bounce around" unless we waited for the
driftIframeResizeevent to fire. At some point between that PR and now,driftIframeResizedoesn't always fire, so the chat window doesn't become visible.The fix
iframeto0, rather than usevisibilityto maintain its state.visibilityto maintain the state of the 'Hide chat` button, and only that button.Testing Notes
You have to be sure there's a
localhostenabled playbook for Storybook to work.