Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KQL] Use term queries for keyword fields #143599

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

lukasolson
Copy link
Member

Summary

Prior to this PR, a KQL query like agent.type: filebeat would generate a match query, regardless of the field type, even though match and match_phrase queries are considered full-text (not term-level) queries. This worked for keyword fields, because internally in Elasticsearch, match and match_phrase queries are rewritten as term queries.

This PR updates the behavior to generate a term query instead. This is one step toward adding support for case-insensitive searches on keyword fields.

Checklist

@lukasolson lukasolson added Feature:KQL KQL Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Oct 18, 2022
@lukasolson lukasolson requested a review from a team as a code owner October 18, 2022 21:22
@lukasolson lukasolson self-assigned this Oct 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasolson lukasolson enabled auto-merge (squash) October 24, 2022 18:07
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #23 / console app console app with comments with single line comments should allow in request body, using #

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 766.8KB 766.9KB +43.0B
apm 3.1MB 3.1MB +43.0B
canvas 1.0MB 1.0MB +43.0B
cloudSecurityPosture 203.4KB 203.4KB +43.0B
controls 492.2KB 492.3KB +43.0B
dashboard 423.5KB 423.6KB +43.0B
dataViewManagement 149.2KB 149.2KB +43.0B
dataVisualizer 571.6KB 571.7KB +43.0B
discover 461.0KB 461.0KB +43.0B
discoverEnhanced 44.6KB 44.7KB +43.0B
fleet 916.7KB 916.8KB +43.0B
graph 454.5KB 454.5KB +43.0B
infra 1009.4KB 1009.5KB +43.0B
inputControlVis 78.3KB 78.3KB +43.0B
lens 1.3MB 1.3MB +43.0B
lists 192.2KB 192.2KB +43.0B
ml 3.4MB 3.4MB +43.0B
monitoring 479.8KB 479.8KB +43.0B
observability 520.6KB 520.7KB +43.0B
osquery 1.0MB 1.0MB +43.0B
securitySolution 9.5MB 9.5MB +43.0B
synthetics 1.0MB 1.0MB +43.0B
threatIntelligence 115.1KB 115.1KB +43.0B
transform 388.9KB 389.0KB +43.0B
triggersActionsUi 676.8KB 676.8KB +43.0B
unifiedFieldList 55.0KB 55.1KB +43.0B
unifiedSearch 260.4KB 260.5KB +43.0B
upgradeAssistant 179.9KB 179.9KB +43.0B
visTypeTimelion 109.2KB 109.3KB +43.0B
visTypeVega 1.7MB 1.7MB +43.0B
visualizations 268.1KB 268.2KB +43.0B
total +1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboardEnhanced 42.8KB 42.8KB +43.0B
data 439.0KB 439.1KB +43.0B
maps 82.1KB 82.2KB +43.0B
stackAlerts 42.3KB 42.4KB +43.0B
timelines 172.8KB 172.8KB +43.0B
total +215.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson merged commit 511f95a into elastic:main Oct 24, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:KQL KQL release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants