[APM] Limit the number of source map artifacts #144963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:APM) |
sorenlouv
added
the
backport:prev-minor
…-ref HEAD~1..HEAD --fix'
sorenlouv
force-pushed
the
fix-sourcemaps-oom
branch
from
0a5e037
to
c040ba4
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2022
(cherry picked from commit 654d531)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2022
# Backport This will backport the following commits from `main` to `8.5`: - [[APM] Limit the number of source map artifacts (#144963)](#144963) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2022-11-12T14:25:55Z","message":"[APM] Limit the number of source map artifacts (#144963)","sha":"654d531efda087b5c297d4fef4a8b9aed0a318ca","branchLabelMapping":{"^v8.6.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","apm:test-plan-regression","backport:prev-minor","v8.6.0"],"number":144963,"url":"https://github.com/elastic/kibana/pull/144963","mergeCommit":{"message":"[APM] Limit the number of source map artifacts (#144963)","sha":"654d531efda087b5c297d4fef4a8b9aed0a318ca"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.6.0","labelRegex":"^v8.6.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/144963","number":144963,"mergeCommit":{"message":"[APM] Limit the number of source map artifacts (#144963)","sha":"654d531efda087b5c297d4fef4a8b9aed0a318ca"}}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
|
Changing |
|
@mistic - do we know if this case will indeed make it to |
|
Thanks @simitt for confirming the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #132799
This issue fixes a problem where
listArtifactswill fetch all source maps artifacts without circuit breakers causing Kibana to crash for users with many source map artifacts.TODO:
GET /api/apm/sourcemaps,'POST /api/apm/sourcemaps',DELETE /api/apm/sourcemaps/{id}