-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] Add support for beats datastream patterns #146184
[Stack Monitoring] Add support for beats datastream patterns #146184
Conversation
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼 Tested both types locally
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @klacabane |
Will add api tests in #147755 |
I'll create a follow up to install apm integration as part of the apm setup script |
…#146184) ## Summary Closes elastic#146686 Update apm and beats queries to read from the Beat package data streams created in elastic/integrations#4708. Also updates health API to fetch from the data streams. API tests follow up in elastic#147755 ### Testing That's a fairly heavy workflow. I'm investigating ways to make that easier - build `beat` package with `elastic-package build`. The package is not published yet so you'll need to pull elastic/integrations#4708 locally - start a stack `elastic-package stack up -v -d --version 8.7.0-SNAPSHOT`. Make sure you do this within `integrations` repo so it picks up the previously built package - start a beat service with `elastic-package service up -v --variant metricbeat_8.7.0` - install both elasticsearch and beat packages from the kibana started by the stack command (`https://localhost:5601`). Nothing shows up in SM if we don't have elasticsearch data. - both packages are prerelease versions and we need to explicitly tell Integrations plugin to show them up[1] - elasticsearch hosts is `https://elasticsearch:9200` and beat _should be_ `http://elastic-package-service_beat_1:5066` but it may differ depending on your docker version - start a Kibana with this branch connected to the elasticsearch instance from the `stack up` command. [see howto](https://github.com/elastic/observability-dev/blob/main/docs/infra-obs-ui/stack-monitoring_integration-packages.md#connecting-a-local-kibana) - navigate to Stack Monitoring and verify the metricbeat is properly monitored - start an apm server with `elastic-package service up -v --variant apm_8.7.0` - navigate to Stack Monitoring and verify apm-server is properly monitored [1] <img width="853" alt="Screenshot 2022-12-01 at 00 20 20" src="https://user-images.githubusercontent.com/5239883/204929352-c7656679-f88c-4013-b1f8-cf7c67d4c830.png"> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Closes #146686
Update apm and beats queries to read from the Beat package data streams created in elastic/integrations#4708. Also updates health API to fetch from the data streams.
API tests follow up in #147755
Testing
That's a fairly heavy workflow. I'm investigating ways to make that easier
beat
package withelastic-package build
. The package is not published yet so you'll need to pull [beat] Create beat package integrations#4708 locallyelastic-package stack up -v -d --version 8.7.0-SNAPSHOT
. Make sure you do this withinintegrations
repo so it picks up the previously built packageelastic-package service up -v --variant metricbeat_8.7.0
https://localhost:5601
). Nothing shows up in SM if we don't have elasticsearch data.https://elasticsearch:9200
and beat should behttp://elastic-package-service_beat_1:5066
but it may differ depending on your docker versionstack up
command. see howtoelastic-package service up -v --variant apm_8.7.0
[1]