[Security Solution] Expandable flyout - add data view title and query bar to rule preview panel #164650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
release_note:fix
Team:Threat Hunting:Investigations
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
To update your PR or re-run it, just comment with: |
PhilippeOberti
approved these changes
Aug 24, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 24, 2023
… bar to rule preview panel (elastic#164650) ## Summary This PR adds `dataViewTitle` to rule preview panel -> define section when data view is available in a rule. This addresses elastic#164529. **How to test** - Create a rule with data view - Generate some alerts, go to alerts page, pick a alert and open expandable flyout - Go to About, open `Rule summary` - Expand `Define` section, the content should match the define section in rule details page for that rule  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 1bb4a52)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 24, 2023
…d query bar to rule preview panel (#164650) (#164717) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Expandable flyout - add data view title and query bar to rule preview panel (#164650)](#164650) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-24T13:44:09Z","message":"[Security Solution] Expandable flyout - add data view title and query bar to rule preview panel (#164650)\n\n## Summary\r\n\r\nThis PR adds `dataViewTitle` to rule preview panel -> define section\r\nwhen data view is available in a rule. This addresses\r\nhttps://github.com//issues/164529.\r\n\r\n**How to test**\r\n- Create a rule with data view\r\n- Generate some alerts, go to alerts page, pick a alert and open\r\nexpandable flyout\r\n- Go to About, open `Rule summary`\r\n- Expand `Define` section, the content should match the define section\r\nin rule details page for that rule\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1bb4a5269242ac2a9ac7cadf4d535e0ea7b5e720","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.10.0","v8.11.0"],"number":164650,"url":"https://github.com/elastic/kibana/pull/164650","mergeCommit":{"message":"[Security Solution] Expandable flyout - add data view title and query bar to rule preview panel (#164650)\n\n## Summary\r\n\r\nThis PR adds `dataViewTitle` to rule preview panel -> define section\r\nwhen data view is available in a rule. This addresses\r\nhttps://github.com//issues/164529.\r\n\r\n**How to test**\r\n- Create a rule with data view\r\n- Generate some alerts, go to alerts page, pick a alert and open\r\nexpandable flyout\r\n- Go to About, open `Rule summary`\r\n- Expand `Define` section, the content should match the define section\r\nin rule details page for that rule\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1bb4a5269242ac2a9ac7cadf4d535e0ea7b5e720"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164650","number":164650,"mergeCommit":{"message":"[Security Solution] Expandable flyout - add data view title and query bar to rule preview panel (#164650)\n\n## Summary\r\n\r\nThis PR adds `dataViewTitle` to rule preview panel -> define section\r\nwhen data view is available in a rule. This addresses\r\nhttps://github.com//issues/164529.\r\n\r\n**How to test**\r\n- Create a rule with data view\r\n- Generate some alerts, go to alerts page, pick a alert and open\r\nexpandable flyout\r\n- Go to About, open `Rule summary`\r\n- Expand `Define` section, the content should match the define section\r\nin rule details page for that rule\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"1bb4a5269242ac2a9ac7cadf4d535e0ea7b5e720"}}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
dataViewTitleto rule preview panel -> define section when data view is available in a rule. This addresses #164529.How to test
Rule summaryDefinesection, the content should match the define section in rule details page for that ruleChecklist