Fix typecheck foundations #167060
Merged
Fix typecheck foundations #167060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on OOM kills of execa/child_proc, log, fix some small issues
delanni
added
ci:hard-typecheck
|
Pinging @elastic/kibana-operations (Team:Operations) |
delanni
force-pushed
the
fix-typecheck-foundations
branch
from
4c522f0
to
3e46165
Compare
delanni
force-pushed
the
fix-typecheck-foundations
branch
from
3e46165
to
e1f2044
Compare
watson
reviewed
Sep 23, 2023
watson
reviewed
Sep 23, 2023
| if (code > 0 && !(code === 143 || code === 130)) { | ||
| throw createFailError(`[${name}] exited with code ${code}`, { | ||
| exitCode: code, | ||
| }); | ||
| } | ||
|
|
||
| // A stop signal of SIGABRT indicates a self-inflicted app crash, | ||
| // then we can't rely on an exit code, because it's not passed | ||
| if (signal === 'SIGABRT') { |
There was a problem hiding this comment.
I'm not 100% confident we can trust that there will not be other signals that might indicate a crash. We don't have to do that in this PR, but in the future I'd like to simplify this code so that it just listens for the rejected promise instead of trying to be so clever and possibly missing some things
There was a problem hiding this comment.
Fair point, here's a fix: d057ecf
watson
reviewed
Sep 23, 2023
| @@ -124,6 +124,9 @@ run( | |||
| '--pretty', | |||
| ...(flagsReader.boolean('verbose') ? ['--verbose'] : []), | |||
| ], | |||
| env: { | |||
| NODE_OPTIONS: '--max-old-space-size=8192', | |||
delanni
commented
Sep 25, 2023
delanni
commented
Sep 25, 2023
| @@ -67,7 +67,7 @@ | |||
| "test:ftr:server": "node scripts/functional_tests_server", | |||
| "test:jest": "node scripts/jest", | |||
| "test:jest_integration": "node scripts/jest_integration", | |||
| "typecheck": "node scripts/type_check" | |||
| "test:type_check": "node scripts/type_check" | |||
There was a problem hiding this comment.
why did you rename the script?
For me test:type_check would mean run typechecks on the test code, or similar - this is not test-related, but typechecking any code
|
@elasticmachine merge upstream |
Ikuni17
approved these changes
Sep 25, 2023
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Ikuni17
added a commit
that referenced
this pull request
Sep 26, 2023
## Summary After merging #167060, `Check Types` is going to fail in the on merge pipeline until all type errors are triaged. For now, lets use the commit diff type check.
watson
pushed a commit
to watson/kibana
that referenced
this pull request
Sep 27, 2023
This is a manual backport of elastic#167060 + recent updates to the backported files
watson
pushed a commit
that referenced
this pull request
Sep 28, 2023
This was referenced Oct 1, 2023
delanni
added a commit
that referenced
this pull request
May 13, 2024
## Summary We've recently seen a handful of step timeouts when running type-checks. While this is not the best solution, it mitigates for potential builds failed, and retries due to timeouts. This PR also contains some cleanup around previous, type-check related jobs (e.g.: the [type-check issue of 2023 august](#167060))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the core part of #166813. The original work seems to grow large, and we'd like to enable a preventive check beforehand to prevent more errors from entering the codebase.
The idea is to have a selective type check that would only check changed files' projects.
ci:hard-typecheckis present, run the regular (but now, working) full typecheck (expected to fail: )cc: @watson