Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solituon] Unskip search bar Serverless Cypress tests #169347

Merged
merged 3 commits into from
Oct 25, 2023
Merged

[Security Solituon] Unskip search bar Serverless Cypress tests #169347

merged 3 commits into from
Oct 25, 2023

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Oct 19, 2023 •
edited by kibanamachine
Loading

Addreses: #161540

Summary

This PR unskips search_bar.cy.ts Serverless Cypress tests.

Details

Besides just unskipping search_bar.cy.ts this PR also makes sure the test isn't flaky by making operator required in fillAddFilterForm(). It turned out the test works only if the Cypress window is in focus when an operator isn't set. Such behavior can lead to test flakiness in CI. This way choosing an operator via keyboard is a safer option.

Flaky test runner

search_bar.cy.ts 150 runs

@maximpn maximpn added test release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.12.0 labels Oct 19, 2023
@maximpn maximpn self-assigned this Oct 19, 2023
@maximpn maximpn changed the title [Security Solituon] Unskip search bar serverless cypress tests [Security Solituon] Unskip search bar Serverless Cypress tests Oct 19, 2023
@maximpn maximpn force-pushed the unskip-search-bar-serverless-cypress-tests branch 2 times, most recently from e9425cf to 6e990b3 Compare October 19, 2023 12:11
@maximpn maximpn force-pushed the unskip-search-bar-serverless-cypress-tests branch from 6e990b3 to e622353 Compare October 19, 2023 18:15
@maximpn
Copy link
Contributor Author

maximpn commented Oct 19, 2023

@elasticmachine merge upstream

@maximpn maximpn marked this pull request as ready for review October 19, 2023 21:09
@maximpn maximpn requested review from a team as code owners October 19, 2023 21:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

janmonschke
janmonschke approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threat Hunting changes LGTM

@maximpn maximpn merged commit 906987c into elastic:main Oct 25, 2023
33 checks passed
@maximpn maximpn deleted the unskip-search-bar-serverless-cypress-tests branch October 25, 2023 09:24
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2023
@maximpn
[Security Solituon] Unskip search bar Serverless Cypress tests (elast…
2327437 
…ic#169347)

**Addreses:** elastic#161540

## Summary

This PR unskips `search_bar.cy.ts` Serverless Cypress tests.

## Details

Besides just unskipping `search_bar.cy.ts` this PR also makes sure the test isn't flaky by making `operator` required in `fillAddFilterForm()`. It turned out the test works only if the Cypress window is in focus when an operator isn't set. Such behavior can lead to test flakiness in CI. This way choosing an operator via keyboard is a safer option.

## Flaky test runner

`search_bar.cy.ts` [150 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3614)

(cherry picked from commit 906987c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 26, 2023
@kibanamachine @maximpn
[8.11] [Security Solituon] Unskip search bar Serverless Cypress tests (…
86a86dd 
…#169347) (#169765)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solituon] Unskip search bar Serverless Cypress tests
(#169347)](#169347)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maxim
Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2023-10-25T09:24:32Z","message":"[Security
Solituon] Unskip search bar Serverless Cypress tests
(#169347)\n\n**Addreses:**
https://github.com/elastic/kibana/issues/161540\r\n\r\n##
Summary\r\n\r\nThis PR unskips `search_bar.cy.ts` Serverless Cypress
tests.\r\n\r\n## Details\r\n\r\nBesides just unskipping
`search_bar.cy.ts` this PR also makes sure the test isn't flaky by
making `operator` required in `fillAddFilterForm()`. It turned out the
test works only if the Cypress window is in focus when an operator isn't
set. Such behavior can lead to test flakiness in CI. This way choosing
an operator via keyboard is a safer option.\r\n\r\n## Flaky test
runner\r\n\r\n`search_bar.cy.ts` [150
runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3614)","sha":"906987c2860b53b91d449bc164957857adddc06a","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","v8.11.0","v8.12.0"],"number":169347,"url":"https://github.com/elastic/kibana/pull/169347","mergeCommit":{"message":"[Security
Solituon] Unskip search bar Serverless Cypress tests
(#169347)\n\n**Addreses:**
https://github.com/elastic/kibana/issues/161540\r\n\r\n##
Summary\r\n\r\nThis PR unskips `search_bar.cy.ts` Serverless Cypress
tests.\r\n\r\n## Details\r\n\r\nBesides just unskipping
`search_bar.cy.ts` this PR also makes sure the test isn't flaky by
making `operator` required in `fillAddFilterForm()`. It turned out the
test works only if the Cypress window is in focus when an operator isn't
set. Such behavior can lead to test flakiness in CI. This way choosing
an operator via keyboard is a safer option.\r\n\r\n## Flaky test
runner\r\n\r\n`search_bar.cy.ts` [150
runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3614)","sha":"906987c2860b53b91d449bc164957857adddc06a"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169347","number":169347,"mergeCommit":{"message":"[Security
Solituon] Unskip search bar Serverless Cypress tests
(#169347)\n\n**Addreses:**
https://github.com/elastic/kibana/issues/161540\r\n\r\n##
Summary\r\n\r\nThis PR unskips `search_bar.cy.ts` Serverless Cypress
tests.\r\n\r\n## Details\r\n\r\nBesides just unskipping
`search_bar.cy.ts` this PR also makes sure the test isn't flaky by
making `operator` required in `fillAddFilterForm()`. It turned out the
test works only if the Cypress window is in focus when an operator isn't
set. Such behavior can lead to test flakiness in CI. This way choosing
an operator via keyboard is a safer option.\r\n\r\n## Flaky test
runner\r\n\r\n`search_bar.cy.ts` [150
runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3614)","sha":"906987c2860b53b91d449bc164957857adddc06a"}}]}]
BACKPORT-->

Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
@maximpn maximpn mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdjere jpdjere jpdjere approved these changes

@janmonschke janmonschke janmonschke approved these changes

Assignees

@maximpn maximpn

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maximpn @elasticmachine @kibana-ci @kibanamachine @janmonschke @jpdjere @banderror