Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sparse vector and dense vector icons #169493

Merged

Conversation

carlosdelest
Copy link
Member

Summary

Add the new dense vector and sparse vector token icons created in elastic/eui#7282, as a follow up to #168186.

Usage in Discover field types:
Screenshot 2023-10-23 at 10 14 26

Usage in Discover field filters:

Screenshot 2023-10-23 at 10 14 44

Checklist

Delete any items that are not applicable to this PR.

@carlosdelest carlosdelest marked this pull request as ready for review October 23, 2023 13:49
@carlosdelest carlosdelest requested a review from a team as a code owner October 23, 2023 13:49
@carlosdelest carlosdelest requested a review from a team October 23, 2023 13:50
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data discovery changes LGTM 👍

Copy link
Contributor

@demjened demjened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlosdelest carlosdelest enabled auto-merge (squash) October 23, 2023 14:20
@carlosdelest carlosdelest merged commit a1955d7 into elastic:main Oct 24, 2023
30 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #5 / Response console File operations: get-file, upload and execute "after all" hook for ""get-file --path" - should retrieve a file" "after all" hook for ""get-file --path" - should retrieve a file"
  • [job] [logs] Defend Workflows Cypress Tests #5 / Response console File operations: get-file, upload and execute "before all" hook for ""get-file --path" - should retrieve a file" "before all" hook for ""get-file --path" - should retrieve a file"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 400.8KB 400.8KB +1.0B
dataVisualizer 614.6KB 614.6KB +1.0B
discover 585.4KB 585.5KB +2.0B
enterpriseSearch 2.6MB 2.6MB +1.0B
eventAnnotationListing 197.9KB 197.9KB +1.0B
graph 388.1KB 388.1KB +1.0B
indexManagement 561.7KB 561.8KB +1.0B
lens 1.4MB 1.4MB +1.0B
maps 2.7MB 2.7MB +1.0B
ml 3.5MB 3.5MB +1.0B
presentationUtil 76.4KB 76.4KB +1.0B
securitySolution 13.0MB 13.0MB +1.0B
stackAlerts 202.9KB 202.9KB +1.0B
unifiedDocViewer 58.4KB 58.4KB +1.0B
unifiedSearch 215.3KB 215.3KB +1.0B
total +16.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
osquery 51.3KB 51.3KB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants