Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fixes problematic test #170222

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[Security Solution] Fixes problematic test #170222

merged 1 commit into from
Oct 31, 2023

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Oct 31, 2023 •
edited
Loading

Summary

After the merge of #169563 seems that there is a test still using resetKibana (I don't know the reason).

In this PR we are fixing that.

Execution in ESS:

Screenshot 2023-10-31 at 12 46 55

Execution in Serverless:

Screenshot 2023-10-31 at 12 49 14

@MadameSheema MadameSheema self-assigned this Oct 31, 2023
@MadameSheema MadameSheema marked this pull request as ready for review October 31, 2023 11:49
@MadameSheema MadameSheema changed the title fixes [Security Solution] Fixes problematic test Oct 31, 2023
@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema mentioned this pull request Oct 31, 2023
Closed
maximpn
maximpn approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MadameSheema MadameSheema enabled auto-merge (squash) October 31, 2023 11:53
@jbudz jbudz disabled auto-merge October 31, 2023 11:58
@jbudz jbudz merged commit d26b373 into elastic:main Oct 31, 2023
12 of 21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 31, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

delanni pushed a commit to delanni/kibana that referenced this pull request Nov 6, 2023
@MadameSheema @delanni
[Security Solution] Fixes problematic test (elastic#170222)
8d71c81 
## Summary

After the merge of elastic#169563 seems
that there is a test still using resetKibana (I don't know the reason).

In this PR we are fixing that.

Execution in ESS:

<img width="2560" alt="Screenshot 2023-10-31 at 12 46 55"
src="https://github.com/elastic/kibana/assets/17427073/dc14eb9a-9ef5-4c35-be83-9f76d9812f8e">

Execution in Serverless:

<img width="2552" alt="Screenshot 2023-10-31 at 12 49 14"
src="https://github.com/elastic/kibana/assets/17427073/28594862-1c0d-40f5-9b9e-dfe7f97584cc">
@MadameSheema MadameSheema deleted the fixes-failing-test branch June 28, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpn maximpn maximpn approved these changes

Assignees

@MadameSheema MadameSheema

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MadameSheema @elasticmachine @kibana-ci @maximpn @jbudz @kibanamachine