Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shareable dashboards] Add share results flyout #170375

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Nov 2, 2023

Summary

Feature branch: #168166.
This PR is going to be merged into main as it's own enhancement independent of the shared dashboards effort.
Closes #167956.
Blocked by #171456.

This updates the Share to spaces flyout with an additional view showing the details results of the share action. Similar to the Copy to spaces flyout, this view shows which objects were shared and unshared from each selected/delected space.

Screenshot 2023-11-01 at 4 54 19 PM

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@cqliu1 cqliu1 force-pushed the share-to-space/share-results-flyout branch from 99fc4fe to b6bc503 Compare November 21, 2023 21:18
@cqliu1 cqliu1 added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Project:ShareToSpace labels Nov 21, 2023
@cqliu1 cqliu1 changed the base branch from shareable-dashboards to main November 21, 2023 21:18
@cqliu1 cqliu1 added the blocked label Nov 21, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 21, 2023

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #82 / machine learning - stack management jobs manage spaces assign to all spaces should edit job space assignment
  • [job] [logs] Jest Tests #4 / ShareToSpaceFlyout allows the form to be filled out to add a space
  • [job] [logs] Jest Tests #4 / ShareToSpaceFlyout allows the form to be filled out to add and remove a space
  • [job] [logs] Jest Tests #4 / ShareToSpaceFlyout allows the form to be filled out to remove a space
  • [job] [logs] Jest Tests #4 / ShareToSpaceFlyout handles related objects correctly adds spaces but does not remove spaces from related objects when adding and removing spaces
  • [job] [logs] Jest Tests #4 / ShareToSpaceFlyout handles related objects correctly adds spaces to related objects when only adding spaces
  • [job] [logs] Jest Tests #4 / ShareToSpaceFlyout handles related objects correctly does not remove spaces from related objects when only removing spaces

History

  • 💔 Build #174762 failed 99fc4feb84b7d039044c353dff72351acebda06b
  • 💔 Build #173880 failed cf1290d6b64e5aba04a9e721bc624137c04e62cd
  • 💔 Build #172674 failed 0bb795276bdc16c95e8f844950c62aa8f4c9456a
  • 💔 Build #172671 failed 7b87ffb237576c937dd793fe37e26540d1051cec

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Project:ShareToSpace Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Share dashboards] All related objects will be automatically shared and show detailed results
2 participants