Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows] Unskip more tests #170401

Merged
merged 15 commits into from
Nov 5, 2023
Merged

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Nov 2, 2023

Fixes:

Unskip:

  • saved_queries.cy.ts (fixed by refactoring from using react-cypress-selector to data-test-subj)
  • live_query_packs.cy.ts - commented out last piece of test (not crucial) that needs more investigation
  • t1_and_t2_analyst.cy.ts (fixed by refactoring from using react-cypress-selector to data-test-subj)
  • add_integration.cy.ts (fixed by refactoring from using react-cypress-selector to data-test-subj)
  • packs_create_edit.cy.ts (fixed by refactoring from using react-cypress-selector to data-test-subj)

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3885
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3887
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3889
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3894
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3895

@tomsonpl tomsonpl self-assigned this Nov 2, 2023
@tomsonpl tomsonpl added the release_note:skip Skip the PR/issue when compiling release notes label Nov 2, 2023
@tomsonpl tomsonpl marked this pull request as ready for review November 4, 2023 08:49
@tomsonpl tomsonpl requested a review from a team as a code owner November 4, 2023 08:49
@tomsonpl tomsonpl added chore Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Feature:Osquery Security Solution Osquery feature v8.12.0 labels Nov 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@tomsonpl tomsonpl requested review from ashokaditya and gergoabraham and removed request for joeypoon and parkiino November 4, 2023 10:00
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1.0MB 1.0MB +316.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@tomsonpl tomsonpl merged commit 5406e2c into elastic:main Nov 5, 2023
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 5, 2023
@tomsonpl
Copy link
Contributor Author

Backported to 8.11 in a bulk PR here: #170930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore Feature:Osquery Security Solution Osquery feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants