…fix'

…-fix'

…fix'

…unting Investigations team (elastic#174658)

…ature registration (elastic#174317)

## Summary

Resolves elastic#172509

Adds ability to register feature capabilities through the assistant
server so they no longer need to be plumbed through the
`ElasticAssistantProvider`, which now also makes them available server
side.

Adds new `/internal/elastic_assistant/capabilities` route and
`useCapabilities()` UI hook for fetching capabilities.

### OpenAPI Codegen

Implemented using the new OpenAPI codegen and bundle packages:
* Includes OpenAPI codegen script and CI action as detailed in:
elastic#166269
* Includes OpenAPI docs bundling script as detailed in:
elastic#171526

To run codegen/bundling locally, cd to
`x-pack/plugins/elastic_assistant/` and run any of the following
commands:

```bash
yarn openapi:generate
yarn openapi:generate:debug
yarn openapi:bundle
```

> [!NOTE]
> At the moment `yarn openapi:bundle` will output an empty bundled
schema since `get_capabilities_route` is an internal route, this is to
be expected. Also, if you don't see the file in your IDE, it's probably
because `target` directories are ignored, so you may need to manually
find/open the bundled schema at it's target location:
`/x-pack/plugins/elastic_assistant/target/openapi/elastic_assistant.bundled.schema.yaml`

### Registering Capabilities 

To register a capability on plugin start, add the following in the
consuming plugin's `start()`:

```ts
plugins.elasticAssistant.registerFeatures(APP_UI_ID, {
  assistantModelEvaluation: config.experimentalFeatures.assistantModelEvaluation,
  assistantStreamingEnabled: config.experimentalFeatures.assistantStreamingEnabled,
});
```

### Declaring Feature Capabilities
Feature capabilities are declared in
`x-pack/packages/kbn-elastic-assistant-common/impl/capabilities/index.ts`:

```ts
/**
 * Interfaces for features available to the elastic assistant
 */
export type AssistantFeatures = { [K in keyof typeof assistantFeatures]: boolean };

export const assistantFeatures = Object.freeze({
  assistantModelEvaluation: false,
  assistantStreamingEnabled: false,
});
```
### Using Capabilities Client Side
And can be fetched client side using the `useCapabilities()` hook ala:

```ts
// Fetch assistant capabilities
const { data: capabilities } = useCapabilities({ http, toasts });
const { assistantModelEvaluation: modelEvaluatorEnabled, assistantStreamingEnabled } = capabilities ?? assistantFeatures;
```

### Using Capabilities Server Side
Or server side within a route (or elsewhere) via the `assistantContext`:

```ts
const assistantContext = await context.elasticAssistant;
const pluginName = getPluginNameFromRequest({ request, logger });
const registeredFeatures = assistantContext.getRegisteredFeatures(pluginName);
if (!registeredFeatures.assistantModelEvaluation) {
  return response.notFound();
}
```

> [!NOTE]
> Note, just as with [registering arbitrary
tools](elastic#172234), features are
registered for a specific plugin, where the plugin name that corresponds
to your application is defined in the `x-kbn-context` header of requests
made from your application, which may be different than your plugin's
registered `APP_ID`.

Perhaps this separation of concerns from one plugin to another isn't
necessary, but it was easy to add matching the behavior of registering
arbitrary tools. We can remove this granularity in favor of global
features if desired.


### Test Steps

* Verify `/internal/elastic_assistant/capabilities` route is called on
security solution page load in dev tools, and that by default the
`Evaluation` UI in setting does is not displayed and `404`'s if manually
called.
* Set the below experimental feature flag in your `kibana.dev.yml` and
observe the feature being enabled by inspecting the capabilities api
response, and that the evaluation feature becomes available:
```
xpack.securitySolution.enableExperimental: [ 'assistantModelEvaluation']
```
* Run the `yarn openapi:*` codegen scripts above and ensure they execute
as expected (code is generated/bundled)

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

## Summary

Fix Crawler stat cards to correctly show connected status.

Crawler connected status is not depending on the last_seen, so it is
updated to show correct stats.


### Checklist


- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

… component (elastic#173886)

This PR is a simple update of our versions file after the recent bumps.

## Summary

This fixes a missing apostrophe in the cURL ingest data example in
Serverless Search.

…astic#169940)

## Summary

Catch error on fetching agent policy since it is optional in process
flow

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

## Summary

Unskips the fullscreen timeline tests.

Looking at the issue described in
elastic#172547, it appears that the
timeline was somehow not opening correctly in some cases. This flakiness
has been removed in elastic#173413, so it
should be possible to unskip these tests.

In addition to unskipping the tests, an unnecessary task execution was
removed and two force clicks were cleaned up.

[Flaky test
runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4834)
(200/200)

fixes elastic#172547

elastic#174123)

## Summary

Add technical preview to the S1 Host isolation flyout

<img width="2056" alt="Zrzut ekranu 2024-01-2 o 21 02 35"
src="https://github.com/elastic/kibana/assets/5188868/813d3a1a-dbc0-4c36-9c43-55613e983306">

<img width="2056" alt="Zrzut ekranu 2024-01-2 o 21 17 58"
src="https://github.com/elastic/kibana/assets/5188868/a863f4dd-1d00-4708-8c4b-c7c8c4dbf0cb">

Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/580

## Fix enrichments cypress tests

[Related PR with removing
ILM](elastic#167916) as it not supported
in serverless. Here the
[error](https://buildkite.com/elastic/kibana-pull-request/builds/179121)
in the CI related to that

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…hars (elastic#174676)

## Summary

Add support for automatic quoting on autocomplete. Added tests.


![esql_quote_special_fields](https://github.com/elastic/kibana/assets/924948/c74d2535-5ff5-42fe-9ec8-285fc4818a3c)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

…ontrols in histogram. (elastic#171638)

- Closes elastic#168825
- Closes elastic#171610
- Closes elastic#167427
- Partially addresses elastic#165192

## Summary

This PR moves the total hits counter closer to the grid, updates
histogram controls and introduces new panel toggle buttons for toggling
fields sidebar and histogram.

<img width="500" alt="Screenshot 2023-12-05 at 15 37 20"
src="https://github.com/elastic/kibana/assets/1415710/5b9bd771-1052-4205-849f-18c21cc299b8">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 29"
src="https://github.com/elastic/kibana/assets/1415710/e5941b27-c497-4d7e-b461-68b66931475a">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 37"
src="https://github.com/elastic/kibana/assets/1415710/97abd32e-9ff2-4d9a-b7e7-b9d6d9cf64db">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 50"
src="https://github.com/elastic/kibana/assets/1415710/10f2b4f4-ec37-41c3-b78b-78c64e14d655">
<img width="400" alt="Screenshot 2023-12-05 at 15 37 59"
src="https://github.com/elastic/kibana/assets/1415710/ef2e28b2-f6ba-4ccb-aea4-3946ba2d5839">
<img width="300" alt="Screenshot 2023-12-05 at 15 38 05"
src="https://github.com/elastic/kibana/assets/1415710/07901ede-0bcb-46a6-a398-4562189fd54f">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 38"
src="https://github.com/elastic/kibana/assets/1415710/17830115-2111-4b8f-ae40-7b5875c06879">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 56"
src="https://github.com/elastic/kibana/assets/1415710/975d475b-280b-495a-b7b7-31c7ade5f21e">
<img width="500" alt="Screenshot 2023-12-05 at 15 43 08"
src="https://github.com/elastic/kibana/assets/1415710/38b6053a-e260-48d8-9591-3f3409df2876">

## Testing

When testing, please check collapsing/expanding the fields sidebar and
histogram. Also for ES|QL mode with suggestions, legacy table, no
results and error prompt, Field Statistics tab, data views without a
time field, light/dark themes.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>

…stic#174734)

## Summary

TLDR; This PR updates the cypress test suite that tests the custom
integration used to set up logs during onboarding.

The PR elastic#171720 surfaced the fact
that this test suite isn't passing, especially given it doesn't run
unless a file with the observability onboarding plugin directory is
modified.

The most notable changes to the test suite, is opting to delete the
provided integration without verifying if it is installed. Why would we
do this one might ask;

- The existing API used to fetch integration packages expects packages
to have assets definition, and given this particular one doesn't have
assets so the request fails more details
[here](elastic#174739).
- With the previous approach it required at least one call to determine
if the integration should be deleted, the only difference here is when
the test kicks off an attempt to delete an integration that doesn't
exist will be made once, but that's handled by setting setting the
cy.request `failOnStatusCode` option as false, so it doesn't error.
- it also unblocks the aforementioned PR

<!--
### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials -->
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
<!--
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
-->

## Summary

Following this PR elastic#171638, this
renames the histogram query to use the word results instead of rows.

<img width="1672" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/9b917bd2-e961-43eb-9aad-6fefd5e38f9c">


### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

## Summary

This is a cleanup. I realized that the fetchFieldsFromESQL function is
already exported by the editor plugin so we can use it from there rather
than duplicating the code.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

## Summary

Due to elastic/elasticsearch#104091 we have to
remove them.

<img width="480" alt="Screenshot 2024-01-11 at 11 24 50"
src="https://github.com/elastic/kibana/assets/924948/c3495554-1a7d-4ae7-9a42-0d9ff785abc5">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Automated by
https://buildkite.com/elastic/package-storage-infra-kibana-discover-release-branches/builds/230

…s and numbers (elastic#174283)

## Summary


Fixes elastic#158878

### Adds two options for the unified search filters
`greater or equal` and `less than`

<img width="897" alt="Screenshot 2024-01-12 at 10 43 14"
src="https://github.com/elastic/kibana/assets/4283304/bd8b502a-8f77-4207-8d48-e8d66851f065">

<img width="898" alt="Screenshot 2024-01-12 at 10 43 31"
src="https://github.com/elastic/kibana/assets/4283304/34a23c56-9334-4d43-8820-175028672760">

### Changes labels for `between` filter pills. 

#### For empty values:
Before:
<img width="637" alt="Screenshot 2024-01-09 at 16 03 47"
src="https://github.com/elastic/kibana/assets/4283304/acd3b6ee-4774-45df-ade9-ab36daa744e1">

After:
<img width="906" alt="Screenshot 2024-01-09 at 15 58 37"
src="https://github.com/elastic/kibana/assets/4283304/318679fe-0078-43a0-815a-7f6936efa884">

#### For only one boundary:
Before:
<img width="641" alt="Screenshot 2024-01-09 at 16 03 34"
src="https://github.com/elastic/kibana/assets/4283304/b8d52abf-2556-4485-9aea-1bf0725b2945">

After:
<img width="733" alt="Screenshot 2024-01-09 at 16 02 09"
src="https://github.com/elastic/kibana/assets/4283304/2fc1b83a-97b5-4717-a244-042a78471fb0">

A few comments:

1. if you negate any of the new filters (gte, lt) it becomes a "not
between" filter.
2. If you only fill one boundary in the `between` filter it converts to
`greater or equal` or `less than` filter

While working on elastic#127036 I
needed scenarios for creating a high number of services, transactions
and errors. I've removed some unnecessary stuff in the scenarios that we
already have elsewhere to make them run faster.

…xists (elastic#171672)

## Summary

Part of elastic#171743

Since we no longer collecting code coverage for functional tests, I
removed flushing on stop signal.

We also noticed a failure on test completion and it is probably due to
resubscribing for logs polling when WebDriver session is already
destroyed. See elastic#171743 for actual logs example

My guess, our current approach to keep fetching WebDriver/Browser logs
based on FTR lifecycle is not very robust:
`takeUntil(lifecycle.cleanup.after$)` keeps emitting until the `cleanup`
stage is finished, and internally we keep resubscribing on WebDriver
failures due to `NoSuchSessionError` and keep trying to fetch logs again
& again. Since we don't re-create WebDriver session, it simply doesn't
make sense. Resubscribing seems useless.

I'm replacing `takeUntil(lifecycle.cleanup.after$)` with
`takeWhile((loggingEntry: logging.Entry)
=>!loggingEntry.message.startsWith(FINAL_LOG_ENTRY_PREFIX))` so that we
stop as soon as we get NoSuchSessionError even if it is before
cleanup.after stage in FTR lifecycle (e.g. browser crashed during the
test run)

For **reviewers**: please give it a try locally and check that you are
able to see browser logs, but no errors/delay on FTR teardown.

How to test:
- start servers & test runner
- let the browser window to be opened by WebDriver and then close it
manually
- check console logs: `browser` logs should be stopped immediately, you
don't see any browser/webdriver logs other than general FTR error

… Hide uninstall tokens for managed policies (elastic#172767)

## Summary

- [x] Hides uninstall tokens for managed policies (we still generate the
uninstall token)
- [x] Hides agent tamper protection switch from UI if policy is managed
- [x] API guard that prevents users from turning on tamper protection if
the policy is managed
- [x] Unit tests

# Screenshot


![managed-uninstall](https://github.com/elastic/kibana/assets/56409205/1c444255-c487-47bf-82d5-2271137cbd70)

…fix'

…fix'