Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] DataViewLazy implementation phase 1 #173948

Merged
merged 117 commits into from
Apr 3, 2024
Merged

[data views] DataViewLazy implementation phase 1 #173948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
117 commits
Select commit Hold shift + click to select a range
bda2de6
initial creation of abstract data view class
mattkime Jul 11, 2023
cdecf14
Merge branch 'main' into data_view_async_fields
mattkime Sep 11, 2023
b9b299c
should save scripted fields now
mattkime Sep 12, 2023
7f81e89
fix extracting field counts from data views
mattkime Sep 12, 2023
5175cb4
fix serialization of fieldAttrs, fix related tests
mattkime Sep 13, 2023
faa87ee
attempt to fix add scripted field
mattkime Sep 13, 2023
8bab954
fix jest test
mattkime Sep 13, 2023
ff14b2f
fix scripted field removal
mattkime Sep 13, 2023
60ef7de
remove unneeded changes
mattkime Sep 13, 2023
6c99ffb
fix delete scripted field api
mattkime Sep 13, 2023
883457a
Merge branch 'main' into data_view_async_fields
mattkime Sep 13, 2023
02c2e3a
fix test
mattkime Sep 13, 2023
6e27b8e
restore getFieldAttrs method
mattkime Sep 13, 2023
0051e34
fix tests
mattkime Sep 13, 2023
e9ab9d4
fix update scripted field rest api
mattkime Sep 13, 2023
ee0f880
remove comment
mattkime Sep 13, 2023
2ebf6c6
Merge branch 'main' into data_view_async_fields
mattkime Sep 29, 2023
107cb29
Merge branch 'main' into data_view_async_fields
mattkime Sep 30, 2023
16389e7
fix toSpec functions
mattkime Oct 1, 2023
2b39fcc
Merge branch 'data_view_async_fields' of github.com:mattkime/kibana i…
mattkime Oct 1, 2023
a010c17
restore removal of count from toSpec if fields aren't included
mattkime Oct 1, 2023
cc0a5a8
Merge branch 'main' into data_views_async_fields_new_class
mattkime Nov 21, 2023
fbfd2b1
Merge branch 'main' of github.com:elastic/kibana into data_views_asyn…
mattkime Nov 23, 2023
e208d2e
partial progress
mattkime Dec 25, 2023
210a5f4
Merge branch 'main' into data_views_async_fields_new_class
mattkime Dec 25, 2023
b0047ae
Merge branch 'main' into data_views_async_fields_new_class
mattkime Jan 12, 2024
559a407
Merge branch 'main' into data_views_async_fields_new_class
mattkime Jan 17, 2024
a2d820b
partial progress, some tests working
mattkime Jan 30, 2024
e2564ab
partial progress, some tests working
mattkime Jan 30, 2024
b3a7199
Merge branch 'main' into data_views_async_fields_new_class
mattkime Feb 5, 2024
173b87a
partial progress, a bunch more tests working
mattkime Feb 6, 2024
f48718c
partial progress, snapshot seems to be working
mattkime Feb 6, 2024
fbe5330
clean up field list loading
mattkime Feb 7, 2024
9cfd496
clean up field list loading
mattkime Feb 7, 2024
4b0c950
runtime field code refactor
mattkime Feb 7, 2024
9feb044
get mapped for runtime field request
mattkime Feb 7, 2024
cea4b13
get mapped for runtime field request
mattkime Feb 7, 2024
df6227b
clean up scripted fields related code
mattkime Feb 8, 2024
9d8d655
type cleanup
mattkime Feb 8, 2024
0a28dab
refactor toSpec
mattkime Feb 19, 2024
3cd8a3e
remove a number of todos
mattkime Feb 20, 2024
5f480d7
toSpec refactor
mattkime Feb 20, 2024
e495fa6
cleanup
mattkime Feb 20, 2024
c93a267
implement getting fields by type, clean up GetFieldsParams
mattkime Feb 20, 2024
2939e25
add restore from spec test
mattkime Feb 20, 2024
ef70e0a
Merge branch 'main' into data_views_async_fields_new_class
mattkime Feb 20, 2024
f8f4b0c
fix log statement
mattkime Feb 28, 2024
63aad2c
prevent runtime on mapped field
mattkime Feb 28, 2024
f774838
return sorted set
mattkime Mar 3, 2024
e9f22eb
add dataViewLazy cache
mattkime Mar 3, 2024
e37fccf
remove comment
mattkime Mar 3, 2024
bf3027b
data view cache should use map instead of custom code
mattkime Mar 3, 2024
ccc5bc0
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 3, 2024
1783085
support field type as param for getting fields
mattkime Mar 3, 2024
83b7028
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 4, 2024
d242e9a
Merge branch 'data_view_cache_to_map' into data_views_async_fields_ne…
mattkime Mar 4, 2024
8fae161
Merge branch 'main' into get_fields_by_type
mattkime Mar 4, 2024
34a4ab0
add integration tests for querying by field type
mattkime Mar 5, 2024
1449b1f
Merge branch 'main' into get_fields_by_type
mattkime Mar 5, 2024
9e183f7
cleanup
mattkime Mar 5, 2024
b650ecd
Merge branch 'get_fields_by_type' of github.com:mattkime/kibana into …
mattkime Mar 5, 2024
6fa0a5c
fix test
mattkime Mar 5, 2024
303603f
fix test
mattkime Mar 5, 2024
fd4c878
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 5, 2024
715c7a2
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 6, 2024
5e0fa60
Merge branch 'get_fields_by_type' into data_views_async_fields_new_class
mattkime Mar 6, 2024
031628d
reduce config.get calls
mattkime Mar 6, 2024
78b4244
add more data view lazy getters and add tests
mattkime Mar 7, 2024
bba8367
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 7, 2024
e4fea50
create and save improvements and tests
mattkime Mar 8, 2024
9a9c37e
Merge branch 'data_views_async_fields_new_class' of github.com:mattki…
mattkime Mar 8, 2024
9428d85
fix mistakes
mattkime Mar 8, 2024
191fd56
fix updateSavedObject references
mattkime Mar 8, 2024
2c8ec00
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 8, 2024
260ee41
fix api integration test
mattkime Mar 9, 2024
d2b53b7
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 9, 2024
a74f3f0
remove unused snapshots
mattkime Mar 9, 2024
bba971f
fix integration api test
mattkime Mar 9, 2024
e33f73e
use dataViewLazy in a couple of rest apis
mattkime Mar 11, 2024
fbdf420
fix disabling of scripted fields
mattkime Mar 11, 2024
d53c80f
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 11, 2024
abdea02
fix disabling scripted fields
mattkime Mar 11, 2024
08e3d62
fix jest test
mattkime Mar 11, 2024
6aa0fa4
increase limits.yml
mattkime Mar 11, 2024
2f386d8
updateSavedObject no longer returns DataView
mattkime Mar 11, 2024
25546aa
fix jest test
mattkime Mar 11, 2024
c5f5383
fix jest test
mattkime Mar 11, 2024
2e491b1
Merge branch 'data_views_async_fields_new_class' into data_views_asyn…
mattkime Mar 11, 2024
0fcbd57
add ability to update via dataViewLazy instances
mattkime Mar 12, 2024
15dfa31
all REST APIs use dataViewLazy
mattkime Mar 12, 2024
a8e5ba2
fix jest tests
mattkime Mar 12, 2024
c5e8da6
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 12, 2024
1d550cb
Merge branch 'data_views_async_fields_new_class_save_changes' into da…
mattkime Mar 12, 2024
d3d98d4
move some code to shared
mattkime Mar 12, 2024
e58a19e
no reason to set id after saving
mattkime Mar 12, 2024
bbcf803
remove unused code
mattkime Mar 13, 2024
ff0cd2c
fix jest test
mattkime Mar 13, 2024
7df68fc
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 13, 2024
6192f45
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 15, 2024
0590ad7
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 18, 2024
0703b7f
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 19, 2024
9ca7b79
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 20, 2024
71fc3f1
Merge branch 'data_views_async_fields_new_class' of github.com:mattki…
mattkime Mar 20, 2024
e6133d1
add field custom description support
mattkime Mar 20, 2024
c2af6be
rename scriptedFieldMap, fix custom description
mattkime Mar 21, 2024
62373eb
REST api improvements, simple type improvement
mattkime Mar 24, 2024
f8df70b
Merge branch 'main' into data_views_async_fields_new_class
mattkime Mar 25, 2024
cd60de6
Merge branch 'data_views_async_fields_new_class' of github.com:mattki…
mattkime Mar 28, 2024
586bf5a
Merge branch 'main' into data_views_async_fields_new_class
mattkime Apr 2, 2024
17cf5b3
merge
mattkime Apr 2, 2024
d66c6ea
Merge branch 'main' into data_views_async_fields_new_class
mattkime Apr 2, 2024
1f8d01e
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Apr 2, 2024
23a54fb
getField improvements
mattkime Apr 2, 2024
0bf272c
Merge branch 'data_views_async_fields_new_class' of github.com:mattki…
mattkime Apr 2, 2024
c99aca1
fix jest test, add mocked function
mattkime Apr 2, 2024
2b20647
simplify field getters
mattkime Apr 2, 2024
68f0692
add mock to jest test
mattkime Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-optimizer/limits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pageLoadAssetSize:
dataViewEditor: 28082
dataViewFieldEditor: 27000
dataViewManagement: 5176
dataViews: 55000
dataViews: 65000
dataVisualizer: 27530
devTools: 38637
discover: 99999
Expand Down
7 changes: 4 additions & 3 deletions src/plugins/data_view_editor/public/components/data_view_flyout_content_container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,10 @@ const DataViewFlyoutContentContainer = ({
editData.name = name;
editData.timeFieldName = timeFieldName;
editData.setAllowHidden(allowHidden);
saveResponse = editData.isPersisted()
? await dataViews.updateSavedObject(editData)
: editData;
if (editData.isPersisted()) {
await dataViews.updateSavedObject(editData);
}
saveResponse = editData;
} else {
saveResponse = persist
? await dataViews.createAndSave(dataViewSpec)
Expand Down
Loading