Percentage display and label when over a hits #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percentage display and label when over a hits
|
This removes showing the value and only shows the percent. Why do we want to remove the existing behavior? |
| if (item) { | ||
| var value = scope.panel.chart === 'bar' ? | ||
| item.datapoint[1] : item.datapoint[1][0][1]; | ||
| var percent = item.series.data[0][1] / (total / 100); |
There was a problem hiding this comment.
This changes the logic. Rather than doing something different for bars, it does the same thing for everything now. Why?
|
I would agree here, this needs to be either supplemental, or as a setting. The panel is called the hits panel, it should display the number of hits. |
|
The number of hits is displayed in legend. |
|
As stated, I'd rather this be changeable as a setting. |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 3, 2016
- Closes elastic#169 - Add type field to multi_match - Closes elastic#175 - Adding global autocomplete rules for aliases - Closes elastic#194 - Adding time_zone to date_histogram agg - Closes elastic#199 - Removed multi_field type and added copy_to - Closes elastic#170 - Add _bunch endpoint - Closes elastic#174 - Adding _search/template endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.