[Defend Workflows][Main port] Unblock fleet setup when validating thousands of uninstall tokens #174737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergoabraham
added
release_note:skip
…s of uninstall tokens (elastic#174535) To unblock Fleet setup when dealing with thousands of agent policies, the query that's used to get decrypted SOs is now performed in batches. The size of the batch is related to [`max_clause_count`](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-settings.html), and it looks like the batch size needs to be smaller than the _half of the value_. `max_clause_count` is at least `1024`, so going with `500` should work on even environments with scarcest resources. With this modification, Fleet setup is successfully performed. Other issues (like errors in Uninstall Tokens table) have not arised. **TODO:** updating/adding tests - you need to find out the value of `indices.query.bool.max_clause_count` on your local machine (is there an easy way?) - for that, checkout `8.12`, - add a lot of Agent Policies: so far we experienced the issue with 2.7k policies on one machine and 3.2k on another. here's a modified version of @dasansol92 's script for adding Agent Policies (without Defend): e6f24b2 - restart Kibana - you should see the `too_many_nested_clauses` error + you should not be able to open any Fleet pages in Kibana (if not, add more policies) - now, switch to this branch without stopping ES - restart Kibana: you should see that fleet setup is successful + you should be able to access Fleet pages Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gergoabraham
force-pushed
the
main-port-unblock-fleet-setup-while-checking-uninstall-tokens-with-thousands-of-policies
branch
from
9d23e1c
to
288ec10
Compare
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
gergoabraham
requested review from
joeypoon,
a team and
paul-tavares
and removed request for
a team
|
@elasticmachine merge upstream |
…-uninstall-tokens-with-thousands-of-policies
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
approved these changes
Jan 12, 2024
|
@elasticmachine merge upstream |
…-uninstall-tokens-with-thousands-of-policies
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
gergoabraham
deleted the
main-port-unblock-fleet-setup-while-checking-uninstall-tokens-with-thousands-of-policies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainport of the following PR merged to8.12:the goal of this port is to sync between
8.12andmain, while other changes are expected to the related uninstall token validation