-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discover query cancellation #176202
discover query cancellation #176202
Conversation
5eb57a8
to
d374023
Compare
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me overall, but I still think a functional test would be valuable here. I looked into it today and managed to write one that I think does a decent job of testing this functionality. Opened a PR against your branch here: ppisljar#13.
I also opened up a separate PR against main
to verify that this PR should still pass if we merge the test in: #176779.
…-test Add Discover request cancellation test
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this and merging in the functional test! LGTM 👍
Summary
adds cancel button to discover search bar
Part of #175426
Checklist
Delete any items that are not applicable to this PR.