Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discover query cancellation #176202

Merged
merged 5 commits into from
Feb 13, 2024
Merged

discover query cancellation #176202

merged 5 commits into from
Feb 13, 2024

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Feb 5, 2024

Summary

adds cancel button to discover search bar

Part of #175426

Checklist

Delete any items that are not applicable to this PR.

@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.13.0 labels Feb 6, 2024
@ppisljar ppisljar marked this pull request as ready for review February 12, 2024 08:47
@ppisljar ppisljar requested a review from a team as a code owner February 12, 2024 08:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@ppisljar
Copy link
Member Author

/ci

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me overall, but I still think a functional test would be valuable here. I looked into it today and managed to write one that I think does a decent job of testing this functionality. Opened a PR against your branch here: ppisljar#13.

I also opened up a separate PR against main to verify that this PR should still pass if we merge the test in: #176779.

…-test

Add Discover request cancellation test
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 573.6KB 574.1KB +458.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this and merging in the functional test! LGTM 👍

@ppisljar ppisljar merged commit 721f48c into elastic:main Feb 13, 2024
17 checks passed
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants