Fix decimals in diff. flamegraph tooltips #178524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
added
bug
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
cauemarcondes
approved these changes
Mar 12, 2024
x-pack/plugins/observability_solution/profiling/public/utils/formatters/as_integer.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: cc @rockdaboot |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cauemarcondes
pushed a commit
to cauemarcondes/kibana
that referenced
this pull request
Mar 13, 2024
In the differential flamegraph tooltips, comparison integer values are shown with decimal digits. This PR fixes it. (cherry picked from commit b3064ba) # Conflicts: # x-pack/plugins/profiling/public/utils/formatters/as_integer.test.ts # x-pack/plugins/profiling/public/utils/formatters/as_integer.ts
cauemarcondes
added a commit
that referenced
this pull request
Mar 13, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [Fix decimals in diff. flamegraph tooltips (#178524)](#178524) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Rühsen","email":"tim.ruhsen@elastic.co"},"sourceCommit":{"committedDate":"2024-03-13T07:13:16Z","message":"Fix decimals in diff. flamegraph tooltips (#178524)\n\nIn the differential flamegraph tooltips, comparison integer values are\r\nshown with decimal digits. This PR fixes it.","sha":"b3064ba67c25e02639a81ed8581c4fdda43e02e3","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:obs-ux-infra_services","v8.13.0","v8.14.0"],"number":178524,"url":"https://github.com/elastic/kibana/pull/178524","mergeCommit":{"message":"Fix decimals in diff. flamegraph tooltips (#178524)\n\nIn the differential flamegraph tooltips, comparison integer values are\r\nshown with decimal digits. This PR fixes it.","sha":"b3064ba67c25e02639a81ed8581c4fdda43e02e3"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178524","number":178524,"mergeCommit":{"message":"Fix decimals in diff. flamegraph tooltips (#178524)\n\nIn the differential flamegraph tooltips, comparison integer values are\r\nshown with decimal digits. This PR fixes it.","sha":"b3064ba67c25e02639a81ed8581c4fdda43e02e3"}}]}] BACKPORT--> Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the differential flamegraph tooltips, comparison integer values are shown with decimal digits. This PR fixes it.