[Dashboard Navigation] GA Links Panel #178999
Conversation
Heenawter
added
Team:Presentation
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
| @@ -25,7 +25,7 @@ | |||
| } | |||
|
|
|||
| @mixin euiFlyout { | |||
| @include kibanaFullBodyHeight(); | |||
| height: calc(100vh - var(--euiFixedHeadersOffset, 0)); | |||
There was a problem hiding this comment.
This fixes a styling issue in Serverless where the height of the secondary edit/add link flyout was incorrect:
| Before | After |
|---|---|
 |
 |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Changes LGTM! Excellent work to you and @nickpeihl - you've built a stable, useful product which is able to be GA'd with such small changes.
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @Heenawter |
Closes #172075
Closes #178396
Summary
In order to move the links panel into general availability, this PR does four main things:
It changes the default of the "Save to library" toggle in the flyout from
truetofalse- this is in response to some early telemetry, which suggests that link panels not saved to the library are more common.It fixes a styling issue in Serverless where the height of the secondary edit/add link flyout was incorrect.
It removes the lab setting for the links panel. The removal of this setting is not a breaking change - it is completely safe to remove this setting regardless of the previous value. Telemetry tracking for this setting is also no longer required.
It removes any reference to "Technical preview" or "Experimental"
Checklist
For maintainers