-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard Navigation] GA Links Panel #178999
Conversation
/ci |
/ci |
/ci |
/ci |
/ci |
@@ -25,7 +25,7 @@ | |||
} | |||
|
|||
@mixin euiFlyout { | |||
@include kibanaFullBodyHeight(); | |||
height: calc(100vh - var(--euiFixedHeadersOffset, 0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! Excellent work to you and @nickpeihl - you've built a stable, useful product which is able to be GA'd with such small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design changes LGTM. Amazing job on this team 🚀!
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @Heenawter |
…l documentation (#194055) Closes #193742 ## Summary The links panel was [GAed in 8.14](#178999), but the [docs](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html) were not updated to reflect this. This PR removes the "technical preview" label from the links panel docs to keep them up-to-date with the current status of the links panel. | Before | After | |--------|--------| | ![image](https://github.com/user-attachments/assets/a110861a-a78b-49ce-81cd-ddb64b15749b) | ![image](https://github.com/user-attachments/assets/e5ddcb39-db5c-4d5d-b107-8877a5e61d15) | ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…l documentation (elastic#194055) Closes elastic#193742 ## Summary The links panel was [GAed in 8.14](elastic#178999), but the [docs](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html) were not updated to reflect this. This PR removes the "technical preview" label from the links panel docs to keep them up-to-date with the current status of the links panel. | Before | After | |--------|--------| | ![image](https://github.com/user-attachments/assets/a110861a-a78b-49ce-81cd-ddb64b15749b) | ![image](https://github.com/user-attachments/assets/e5ddcb39-db5c-4d5d-b107-8877a5e61d15) | ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 3a806b8)
… from links panel documentation (#194055) (#194155) # Backport This will backport the following commits from `main` to `8.x`: - [[Links Panel] [Docs] Remove "technical preview" label from links panel documentation (#194055)](#194055) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-26T14:06:21Z","message":"[Links Panel] [Docs] Remove \"technical preview\" label from links panel documentation (#194055)\n\nCloses https://github.com/elastic/kibana/issues/193742\r\n\r\n## Summary\r\n\r\nThe links panel was [GAed in\r\n8.14](#178999), but the\r\n[docs](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)\r\nwere not updated to reflect this. This PR removes the \"technical\r\npreview\" label from the links panel docs to keep them up-to-date with\r\nthe current status of the links panel.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n![image](https://github.com/user-attachments/assets/a110861a-a78b-49ce-81cd-ddb64b15749b)\r\n|\r\n![image](https://github.com/user-attachments/assets/e5ddcb39-db5c-4d5d-b107-8877a5e61d15)\r\n|\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"3a806b8f946650879be714895f79ed6e0a688a7d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Presentation","loe:small","release_note:skip","impact:low","v9.0.0","docs","backport:prev-minor","v8.16.0"],"title":"[Links Panel] [Docs] Remove \"technical preview\" label from links panel documentation","number":194055,"url":"https://github.com/elastic/kibana/pull/194055","mergeCommit":{"message":"[Links Panel] [Docs] Remove \"technical preview\" label from links panel documentation (#194055)\n\nCloses https://github.com/elastic/kibana/issues/193742\r\n\r\n## Summary\r\n\r\nThe links panel was [GAed in\r\n8.14](#178999), but the\r\n[docs](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)\r\nwere not updated to reflect this. This PR removes the \"technical\r\npreview\" label from the links panel docs to keep them up-to-date with\r\nthe current status of the links panel.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n![image](https://github.com/user-attachments/assets/a110861a-a78b-49ce-81cd-ddb64b15749b)\r\n|\r\n![image](https://github.com/user-attachments/assets/e5ddcb39-db5c-4d5d-b107-8877a5e61d15)\r\n|\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"3a806b8f946650879be714895f79ed6e0a688a7d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194055","number":194055,"mergeCommit":{"message":"[Links Panel] [Docs] Remove \"technical preview\" label from links panel documentation (#194055)\n\nCloses https://github.com/elastic/kibana/issues/193742\r\n\r\n## Summary\r\n\r\nThe links panel was [GAed in\r\n8.14](#178999), but the\r\n[docs](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)\r\nwere not updated to reflect this. This PR removes the \"technical\r\npreview\" label from the links panel docs to keep them up-to-date with\r\nthe current status of the links panel.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n![image](https://github.com/user-attachments/assets/a110861a-a78b-49ce-81cd-ddb64b15749b)\r\n|\r\n![image](https://github.com/user-attachments/assets/e5ddcb39-db5c-4d5d-b107-8877a5e61d15)\r\n|\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"3a806b8f946650879be714895f79ed6e0a688a7d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
…l documentation (elastic#194055) Closes elastic#193742 ## Summary The links panel was [GAed in 8.14](elastic#178999), but the [docs](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html) were not updated to reflect this. This PR removes the "technical preview" label from the links panel docs to keep them up-to-date with the current status of the links panel. | Before | After | |--------|--------| | ![image](https://github.com/user-attachments/assets/a110861a-a78b-49ce-81cd-ddb64b15749b) | ![image](https://github.com/user-attachments/assets/e5ddcb39-db5c-4d5d-b107-8877a5e61d15) | ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
… from links panel documentation (elastic#194055) (elastic#194155) # Backport This will backport the following commits from `main` to `8.x`: - [[Links Panel] [Docs] Remove "technical preview" label from links panel documentation (elastic#194055)](elastic#194055) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-26T14:06:21Z","message":"[Links Panel] [Docs] Remove \"technical preview\" label from links panel documentation (elastic#194055)\n\nCloses https://github.com/elastic/kibana/issues/193742\r\n\r\n## Summary\r\n\r\nThe links panel was [GAed in\r\n8.14](elastic#178999), but the\r\n[docs](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)\r\nwere not updated to reflect this. This PR removes the \"technical\r\npreview\" label from the links panel docs to keep them up-to-date with\r\nthe current status of the links panel.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n![image](https://github.com/user-attachments/assets/a110861a-a78b-49ce-81cd-ddb64b15749b)\r\n|\r\n![image](https://github.com/user-attachments/assets/e5ddcb39-db5c-4d5d-b107-8877a5e61d15)\r\n|\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"3a806b8f946650879be714895f79ed6e0a688a7d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Presentation","loe:small","release_note:skip","impact:low","v9.0.0","docs","backport:prev-minor","v8.16.0"],"title":"[Links Panel] [Docs] Remove \"technical preview\" label from links panel documentation","number":194055,"url":"https://github.com/elastic/kibana/pull/194055","mergeCommit":{"message":"[Links Panel] [Docs] Remove \"technical preview\" label from links panel documentation (elastic#194055)\n\nCloses https://github.com/elastic/kibana/issues/193742\r\n\r\n## Summary\r\n\r\nThe links panel was [GAed in\r\n8.14](elastic#178999), but the\r\n[docs](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)\r\nwere not updated to reflect this. This PR removes the \"technical\r\npreview\" label from the links panel docs to keep them up-to-date with\r\nthe current status of the links panel.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n![image](https://github.com/user-attachments/assets/a110861a-a78b-49ce-81cd-ddb64b15749b)\r\n|\r\n![image](https://github.com/user-attachments/assets/e5ddcb39-db5c-4d5d-b107-8877a5e61d15)\r\n|\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"3a806b8f946650879be714895f79ed6e0a688a7d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194055","number":194055,"mergeCommit":{"message":"[Links Panel] [Docs] Remove \"technical preview\" label from links panel documentation (elastic#194055)\n\nCloses https://github.com/elastic/kibana/issues/193742\r\n\r\n## Summary\r\n\r\nThe links panel was [GAed in\r\n8.14](elastic#178999), but the\r\n[docs](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)\r\nwere not updated to reflect this. This PR removes the \"technical\r\npreview\" label from the links panel docs to keep them up-to-date with\r\nthe current status of the links panel.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n![image](https://github.com/user-attachments/assets/a110861a-a78b-49ce-81cd-ddb64b15749b)\r\n|\r\n![image](https://github.com/user-attachments/assets/e5ddcb39-db5c-4d5d-b107-8877a5e61d15)\r\n|\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"3a806b8f946650879be714895f79ed6e0a688a7d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
Closes #172075
Closes #178396
Summary
In order to move the links panel into general availability, this PR does four main things:
It changes the default of the "Save to library" toggle in the flyout from
true
tofalse
- this is in response to some early telemetry, which suggests that link panels not saved to the library are more common.It fixes a styling issue in Serverless where the height of the secondary edit/add link flyout was incorrect.
It removes the lab setting for the links panel. The removal of this setting is not a breaking change - it is completely safe to remove this setting regardless of the previous value. Telemetry tracking for this setting is also no longer required.
It removes any reference to "Technical preview" or "Experimental"
Checklist
For maintainers