Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSV] Include custom field label in CSV reports #181565

Merged
merged 4 commits into from
Apr 26, 2024
Merged

[CSV] Include custom field label in CSV reports #181565

merged 4 commits into from
Apr 26, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Apr 24, 2024 •
edited
Loading

Summary

This PR adds field.customLabel to CSV reports (column names) if available.

Before:
Screenshot 2024-04-24 at 15 16 45

After:
Screenshot 2024-04-24 at 15 17 04

Checklist

@jughosta jughosta added release_note:fix (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Apr 24, 2024
@jughosta jughosta self-assigned this Apr 24, 2024
@jughosta
Copy link
Contributor Author

/ci

@jughosta jughosta marked this pull request as ready for review April 24, 2024 15:06
@jughosta jughosta requested a review from a team as a code owner April 24, 2024 15:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Dosant
Dosant approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@jughosta jughosta added backport:skip This commit does not require backporting release_note:enhancement and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:fix labels Apr 26, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

davismcphee
davismcphee approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jughosta jughosta merged commit 4331175 into elastic:main Apr 26, 2024
16 checks passed
@jughosta jughosta deleted the 100374-custom-label-in-csv branch April 26, 2024 18:43
yuliacech pushed a commit to yuliacech/kibana that referenced this pull request May 3, 2024
@jughosta @kibanamachine @yuliacech
[CSV] Include custom field label in CSV reports (elastic#181565)
62715ce 
- Closes elastic#100374

## Summary

This PR adds `field.customLabel` to CSV reports (column names) if
available.

Before:
<img width="800" alt="Screenshot 2024-04-24 at 15 16 45"
src="https://github.com/elastic/kibana/assets/1415710/870c9146-dd3a-4cc6-a12f-f67fbd7196f5">

After:
<img width="800" alt="Screenshot 2024-04-24 at 15 17 04"
src="https://github.com/elastic/kibana/assets/1415710/7f870899-71a2-42e7-ade4-d92acca9b96a">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting :DataDiscovery/fix-it-week (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:enhancement Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reporting] Add customer label field name in CSV export
6 participants
@jughosta @elasticmachine @kibana-ci @Dosant @davismcphee @kibanamachine