[ML] Anomaly Detection: Adds 'Add to dashboard' action for Single Metric Viewer #182538
Conversation
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
added
Feature:Anomaly Detection
| defaultMessage="Add to dashboard" | ||
| /> | ||
| ), | ||
| icon: 'search', |
There was a problem hiding this comment.
I don't think this icon is needed. The actions for the anomaly swim lane and anomaly charts only use text.
There was a problem hiding this comment.
Removed in eeacd0d
|
|
||
| return ( | ||
| <> | ||
| <EuiFlexGroup style={{ float: 'right' }} alignItems="center"> |
There was a problem hiding this comment.
I know you just moved this code, but I wonder if we can get rid of the inline styles? Do we need the float here?
| toggleShowModelBoundsHandler: () => void; | ||
| toggleShowAnnotationsHandler: () => void; | ||
| toggleShowForecastHandler: () => void; |
There was a problem hiding this comment.
Shall we follow the naming convention for controlled component?
| toggleShowModelBoundsHandler: () => void; | |
| toggleShowAnnotationsHandler: () => void; | |
| toggleShowForecastHandler: () => void; | |
| onShowModelBoundsChange: () => void; | |
| onShowAnnotationsChange: () => void; | |
| onShowForecastChange: () => void; |
There was a problem hiding this comment.
Good call - updated in eacccc6
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
szabosteve
changed the title
Summary
Adds an action to add the Single Metric Viewer to new or existing dashboards.
Related meta issue: #181272
SMV-add-to-dash.mp4
Checklist
Delete any items that are not applicable to this PR.