[OBX-UI-MNGMT] Align the Metric rule charts by using Lens in Alert details page and Creation Rule flyout

[fkanout]

Summary

Fixes #184922
Fixes #184574

It uses the RuleConditionChart, a.k.a Lens chart, for the Metric Threshold rule.

Implemented in both places:

• Metric Alert Details page
  

• Rule creation flyout
  

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[maryam-saeidi]

/ci

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[fkanout]

adding warning threshold

[fkanout]

adding warning threshold

Added ✅

[benakansara]

Code changes LGTM.

While testing, I noticed that when removing "warning" threshold, its reference line is not removed from the chart.

Screen.Recording.2024-06-19.at.12.59.11.mov

[fkanout]

Code changes LGTM.

While testing, I noticed that when removing "warning" threshold, its reference line is not removed from the chart.

Screen.Recording.2024-06-19.at.12.59.11.mov

Nice catch @benakansara! I fixed that, and I'm updating the chart tests too.

[jennypavlova]

Infra code changes LGTM

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: f0d3846
• Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-184950-f0d384678267
• Observability Deployment

Failed CI Steps

• FTR Configs #41

Test Failures

• [job] [logs] FTR Configs #41 / transform basic license "after all" hook: afterTestSuite.trigger in "transform basic license"
• [job] [logs] FTR Configs #41 / transform basic license transform - creation - runtime mappings & saved search "after all" hook in "transform - creation - runtime mappings & saved search"
• [job] [logs] FTR Configs #41 / transform basic license transform - creation - runtime mappings & saved search creation_saved_search "after all" hook: afterTestSuite.trigger in "creation_saved_search"
• [job] [logs] FTR Configs #41 / transform basic license transform - creation - runtime mappings & saved search creation_saved_search "before all" hook in "creation_saved_search"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
infra	1612	1580	-32

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
observability	689	695	+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
infra	1.6MB	1.5MB	-32.4KB
observability	306.5KB	288.2KB	-18.3KB
total			-50.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
observability	15	16	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
infra	101.8KB	101.8KB	-7.0B
observability	123.3KB	142.2KB	+18.9KB
total			+18.9KB

Unknown metric groups

API count

id	before	after	diff
observability	698	704	+6

async chunk count

id	before	after	diff
infra	17	18	+1
observability	11	10	-1
total			-0

History

• 💛 Build #216728 was flaky 0011164
• 💔 Build #216676 failed 7e33139
• 💔 Build #216630 failed 61e06bb
• 💛 Build #215677 was flaky 35543c2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @fkanout

[benakansara]

LGTM